Issue 407893004: Enable object evacuation verifier. Perform verification of evacuation candidates when sweeping is d…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 407893004: Enable object evacuation verifier. Perform verification of evacuation candidates when sweeping is d… (Closed)

Created:
6 years, 5 months ago by Hannes Payer (out of office)

Modified:
6 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Enable object evacuation verifier. Perform verification of evacuation candidates when sweeping is done. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22508

Patch Set 2 : #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -31 lines)			Patch
	M	src/mark-compact.cc	View	1	5 chunks	+27 lines, -31 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/407893004/diff/20001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/407893004/diff/20001/src/mark-compact.cc#newcode174 src/mark-compact.cc:174: heap_object = iterator.Next()) { nit: Indentation looks off.

6 years, 5 months ago (2014-07-21 14:58:55 UTC) #2

Hannes Payer (out of office)

https://codereview.chromium.org/407893004/diff/20001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/407893004/diff/20001/src/mark-compact.cc#newcode174 src/mark-compact.cc:174: heap_object = iterator.Next()) { On 2014/07/21 14:58:55, Michael Starzinger ...

6 years, 5 months ago (2014-07-21 15:11:42 UTC) #3

Hannes Payer (out of office)

6 years, 5 months ago (2014-07-21 15:12:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22508 (presubmit successful).

Expand Messages | Collapse Messages

Issue 407893004: Enable object evacuation verifier. Perform verification of evacuation candidates when sweeping is d… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages