Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1421)

Issue 407893003: Implement clearListener() method for PositionObserver to clear all registered listeners when Con (Closed)

Created:
6 years, 5 months ago by wajahat
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Abhishek, Jitu( very slow this week)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Implement clearListener() method for PositionObserver to clear all registered listeners when ContentViewCore is destroyed. PositionObserver listeners are not cleared and left as it is which will eventually not go for garbage collection. Hence listeners should be cleared when ContentViewCore is destroyed. BUG=None. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285244

Patch Set 1 #

Total comments: 4

Patch Set 2 : changes incorporated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/PositionObserver.java View 1 chunk +5 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ViewPositionObserver.java View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
wajahat
PTAL!
6 years, 5 months ago (2014-07-21 14:35:49 UTC) #1
wajahat
6 years, 5 months ago (2014-07-21 14:39:28 UTC) #2
Yaron
https://codereview.chromium.org/407893003/diff/1/content/public/android/java/src/org/chromium/content/browser/ViewPositionObserver.java File content/public/android/java/src/org/chromium/content/browser/ViewPositionObserver.java (left): https://codereview.chromium.org/407893003/diff/1/content/public/android/java/src/org/chromium/content/browser/ViewPositionObserver.java#oldcode64 content/public/android/java/src/org/chromium/content/browser/ViewPositionObserver.java:64: if (mListeners.contains(listener)) return; This is different than what ObserverList ...
6 years, 5 months ago (2014-07-22 19:20:25 UTC) #3
wajahat
Changes Incorporated as per comments. PTAL! https://codereview.chromium.org/407893003/diff/1/content/public/android/java/src/org/chromium/content/browser/ViewPositionObserver.java File content/public/android/java/src/org/chromium/content/browser/ViewPositionObserver.java (left): https://codereview.chromium.org/407893003/diff/1/content/public/android/java/src/org/chromium/content/browser/ViewPositionObserver.java#oldcode64 content/public/android/java/src/org/chromium/content/browser/ViewPositionObserver.java:64: if (mListeners.contains(listener)) return; ...
6 years, 5 months ago (2014-07-23 04:24:16 UTC) #4
Yaron
lgtm
6 years, 5 months ago (2014-07-23 18:25:59 UTC) #5
wajahat
The CQ bit was checked by wajahat.s@samsung.com
6 years, 5 months ago (2014-07-24 05:21:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wajahat.s@samsung.com/407893003/20001
6 years, 5 months ago (2014-07-24 05:24:12 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 07:24:34 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 14:11:10 UTC) #9
Message was sent while issue was closed.
Change committed as 285244

Powered by Google App Engine
This is Rietveld 408576698