Prevent a window from being put into fullscreen upon startup on desktop Linux

Prevent a window from being put into fullscreen upon startup on desktop Linux

The GTK port had logic which prevented windows from being the same size as the
monitor because some window managers would put those windows into fullscreen.
(gtk_window_util::SetWindowSize()). This CL implements this logic for the
Linux aura port

BUG=382126
TEST=Manual, see instructions below

Testing steps:
1) Open a browser window in the Gnome Classic window manager (this is very
   important)
2) Maximize the browser window, fullscreen with <F11>, then unfullscreen it.
3) Close Chrome.
4) Reopen Chrome. The browser window should be maximized.
5) Unmaximize the browser window and ensure that it is possible to resize the
   browser window.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285906

[pkotwicz, 2014-07-25 19:31:52]

Elliot, PTAL

This should hopefully fix the remaining bugs wrt to putting Chrome inadvertently
into fullscreen

https://codereview.chromium.org/407893002/diff/20001/ui/views/widget/desktop_...
File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right):

https://codereview.chromium.org/407893002/diff/20001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:525: if
(HasWMSpecProperty("_NET_WM_STATE_FULLSCREEN")) {
It is possible for a user to still inadvertently put the window into fullscreen
by resizing it or by dragging the window header. The code here allows the user
to get out of fullscreen if they press the maximize button enough times.

https://codereview.chromium.org/407893002/diff/20001/ui/views/widget/desktop_...
ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1202:
requested_size.height() - 1);
Ensuring that the window's non-maximized size does not match the screen's width
or height seems sufficient to prevent a window which is opened as maximized from
getting put into fullscreen when unmaximized.

[Elliot Glaysher, 2014-07-25 19:44:17]

lgtm

[pkotwicz, 2014-07-28 13:41:18]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-07-28 13:42:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/407893002/40001

[commit-bot: I haz the power, 2014-07-28 14:52:53]

Change committed as 285906