Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 407883005: Remove 'WebURLRequest::TargetType' from PrefetchHelper. (Closed)

Created:
6 years, 5 months ago by Mike West
Modified:
6 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, jochen (gone - plz use gerrit)
Project:
chromium
Visibility:
Public.

Description

Remove 'WebURLRequest::TargetType' from PrefetchHelper. 'WebURLRequest::TargetType' has been dropped in Blink in favor of 'RequestContext' and 'FrameType', matching the Fetch specification's changes, and allowing both more granularity in various Blink-side checks and more clarity around the thing that caused a request, and the frame that the request affects. This CL should have zero practical effect, as it's simply hoisting the translation work that 'WebURLRequest::setTargetType' is already doing up into the content layer to bring us one step closer to removing the concept entirely. BUG=390497 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284565

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/renderer/prefetch_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Mike West
thestig@: Mind taking a look at this CL? jochen@: FYI, since you're on all the ...
6 years, 5 months ago (2014-07-21 16:17:43 UTC) #1
Lei Zhang
lgtm
6 years, 5 months ago (2014-07-21 18:57:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/407883005/1
6 years, 5 months ago (2014-07-21 18:59:53 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 20:50:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 21:31:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/41248)
6 years, 5 months ago (2014-07-21 21:31:54 UTC) #6
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-21 21:32:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/407883005/1
6 years, 5 months ago (2014-07-21 21:35:01 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 00:46:44 UTC) #9
Message was sent while issue was closed.
Change committed as 284565

Powered by Google App Engine
This is Rietveld 408576698