Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 407883003: Revert of Remove deprecated extension notifications from ProcessManager (Closed)

Created:
6 years, 5 months ago by tapted
Modified:
6 years, 5 months ago
Reviewers:
Devlin, limasdf
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove deprecated extension notifications from ProcessManager (https://codereview.chromium.org/397743005/) Reason for revert: Suspected for Invalid Write / Unadressable / Uninitialized errors in Linux Tests (valgrind)(3) via ProcessManagerTest.ProcessGrouping and others starting http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%283%29/builds/38965 Errors like Invalid write of size 8 ObserverListBase<autofill::PersonalDataManagerObserver>::AddObserver(autofill::PersonalDataManagerObserver*) (base/observer_list.h:162) autofill::PersonalDataManager::AddObserver(autofill::PersonalDataManagerObserver*) (components/autofill/core/browser/personal_data_manager.cc:225) ... extensions::ProcessManagerTest::ProcessManagerTest() (extensions/browser/process_manager_unittest.cc:39) and a range of uninitialized reads/jumps. Original issue's description: > Remove deprecated extension notifications from ProcessManager and use ExtensionRegistry instead. > > BUG=354046 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284366 TBR=rdevlin.cronin@chromium.org,limasdf@gmail.com NOTREECHECKS=true NOTRY=true BUG=354046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -49 lines) Patch
M extensions/browser/process_manager.h View 4 chunks +1 line, -16 lines 0 comments Download
M extensions/browser/process_manager.cc View 3 chunks +33 lines, -27 lines 0 comments Download
M extensions/browser/process_manager_unittest.cc View 5 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
Created Revert of Remove deprecated extension notifications from ProcessManager
6 years, 5 months ago (2014-07-21 01:56:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/407883003/1
6 years, 5 months ago (2014-07-21 01:56:58 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 01:57:46 UTC) #3
Message was sent while issue was closed.
Change committed as 284387

Powered by Google App Engine
This is Rietveld 408576698