Issue 407763002: Revert of cc: Remove tilings from recycle tree when active tree removes them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 407763002: Revert of cc: Remove tilings from recycle tree when active tree removes them. (Closed)

Created:
6 years, 5 months ago by tonyg

Modified:
6 years, 5 months ago

Reviewers:
danakj, vmpstr

CC:
chromium-reviews, cc-bugs_chromium.org, jeremy

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Revert of cc: Remove tilings from recycle tree when active tree removes them. (https://codereview.chromium.org/400633004/) Reason for revert: Related crashes are showing up on Android bots. Details in bug. BUG=395398 Original issue's description: > cc: Remove tilings from recycle tree when active tree removes them. > > This patch is the second part of ensuring that recycle tree does not > contain any unshared tiles. > > This is done by removing recycle tree tilings when active tree removes > those tilings. > > BUG=393802 > R=danakj > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284311 TBR=danakj@chromium.org,vmpstr@chromium.org NOTREECHECKS=true NOTRY=true BUG=393802 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284343

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -24 lines)			Patch
M	cc/layers/picture_layer_impl.cc	View	2 chunks	+1 line, -15 lines	0 comments	Download
M	cc/trees/layer_tree_host_impl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/trees/layer_tree_impl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/trees/layer_tree_impl.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 3 (0 generated)

tonyg

Created Revert of cc: Remove tilings from recycle tree when active tree removes them.

6 years, 5 months ago (2014-07-19 20:28:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/407763002/1

6 years, 5 months ago (2014-07-19 20:29:35 UTC) #2

Message was sent while issue was closed.

Change committed as 284343