Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 407753002: Calculate the correct available height for content (Closed)

Created:
6 years, 5 months ago by rhogan
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Calculate the correct available height for content The available height for content is the interior of the content box, not the border box. http://www.w3.org/TR/CSS2/visudet.html#propdef-height http://www.w3.org/TR/CSS2/visudet.html#inline-replaced-height BUG=236043 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178693

Patch Set 1 #

Patch Set 2 : Updated #

Patch Set 3 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
A LayoutTests/fast/replaced/available-height-for-content.html View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/fast/replaced/available-height-for-content-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
rhogan
The two tables test failures are progressions.
6 years, 5 months ago (2014-07-21 17:30:59 UTC) #1
leviw_travelin_and_unemployed
Can you add a link to the spec describing this in your description, and in ...
6 years, 5 months ago (2014-07-21 20:14:15 UTC) #2
rhogan
The CQ bit was checked by robhogan@gmail.com
6 years, 5 months ago (2014-07-22 19:14:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robhogan@gmail.com/407753002/40001
6 years, 5 months ago (2014-07-22 19:14:44 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-22 20:27:57 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 20:58:41 UTC) #6
Message was sent while issue was closed.
Change committed as 178693

Powered by Google App Engine
This is Rietveld 408576698