Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Issue 407733005: Update V8 to version 3.28.30 (based on bleeding_edge revision r22489). (Closed)

Created:
6 years, 5 months ago by Michael Achenbach
Modified:
6 years, 5 months ago
Reviewers:
Sven Panne
CC:
chromium-reviews, Toon Verwaest
Project:
chromium
Visibility:
Public.

Description

Update V8 to version 3.28.30 (based on bleeding_edge revision r22489). Please reply to the V8 sheriff svenpanne@chromium.org in case of problems. TBR=svenpanne@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Michael Achenbach
6 years, 5 months ago (2014-07-21 08:19:30 UTC) #1
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 5 months ago (2014-07-21 08:19:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/407733005/1
6 years, 5 months ago (2014-07-21 08:20:02 UTC) #3
Sven Panne
LGTM. @Toon: What's the state of the necessary rebasing of the webkit test expectations?
6 years, 5 months ago (2014-07-21 09:27:20 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 11:48:16 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 12:06:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/173036)
6 years, 5 months ago (2014-07-21 12:06:53 UTC) #7
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 5 months ago (2014-07-21 13:35:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/407733005/1
6 years, 5 months ago (2014-07-21 13:36:00 UTC) #9
commit-bot: I haz the power
Change committed as 284420
6 years, 5 months ago (2014-07-21 13:37:33 UTC) #10
Peter Kasting
6 years, 5 months ago (2014-07-22 00:44:41 UTC) #11
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/405313002/ by pkasting@chromium.org.

The reason for reverting is: Seems to be causing
xss-DENIED-method-with-iframe-proto.html to time out on multiple bots; see
http://crbug.com/395882 ..

Powered by Google App Engine
This is Rietveld 408576698