chrome/browser/ui/webui/print_preview/print_preview_ui.cc - Issue 407733002: [JS Changes] Support NumCopies print preset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui.cc

Issue 407733002: [JS Changes] Support NumCopies print preset (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Name changes Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/print_preview/print_preview_ui.cc

diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc

index 7d9e944f4f7085e870f77e415761fb18a490753b..737f7ee0ba18e7438bebef7580705bc545cfe3f2 100644

--- a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc

+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc

@@ -628,9 +628,12 @@ void PrintPreviewUI::OnReloadPrintersList() {

void PrintPreviewUI::OnSetOptionsFromDocument(

const PrintHostMsg_SetOptionsFromDocument_Params& params) {

- // Notify WebUI that print scaling is disabled

- if (params.is_scaling_disabled)

- web_ui()->CallJavascriptFunction("printScalingDisabledForSourcePDF");

+ base::DictionaryValue options;

+ options.SetBoolean(

+ printing::kSettingFitToPageEnabled,

Aleksey Shlyapnikov 2014/11/20 18:56:56 Why are you using kSettingFitToPageEnabled name he

Nikhil 2014/11/21 10:45:32 Thanks for reviewing this! I've introduced kSettin

+ params.is_scaling_disabled);

+ options.SetInteger(printing::kSettingCopies, params.copies);

+ web_ui()->CallJavascriptFunction("printPresetOptionsFromDocument", options);

Aleksey Shlyapnikov 2014/11/20 18:56:56 Since you're not calling printScalingDisabledForSo

Nikhil 2014/11/21 10:45:32 Done.

}

// static