Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1313)

Unified Diff: Source/devtools/front_end/console/ConsoleView.js

Issue 407723002: DevTools: [Console] "Show all messages" checkbox is visible only if a few targets are available (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address vsevik's comment Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/console/ConsoleView.js
diff --git a/Source/devtools/front_end/console/ConsoleView.js b/Source/devtools/front_end/console/ConsoleView.js
index 4d5e68cfa53f4d1eceeed34f455de410b39de0b3..9da77e44aa3ca27b72adeb0566ff3f7d28990480 100644
--- a/Source/devtools/front_end/console/ConsoleView.js
+++ b/Source/devtools/front_end/console/ConsoleView.js
@@ -112,8 +112,7 @@ WebInspector.ConsoleView = function(hideContextSelector)
this._showAllMessagesCheckbox.inputElement.checked = true;
this._showAllMessagesCheckbox.inputElement.addEventListener("change", this._updateMessageList.bind(this), false);
- if (!WebInspector.experimentsSettings.workersInMainWindow.isEnabled())
- this._showAllMessagesCheckbox.element.classList.add("hidden");
+ this._showAllMessagesCheckbox.element.classList.add("hidden");
statusBarElement.appendChild(this._showAllMessagesCheckbox.element);
@@ -204,6 +203,8 @@ WebInspector.ConsoleView.prototype = {
{
this._viewport.invalidate();
target.runtimeModel.executionContexts().forEach(this._executionContextCreated, this);
+ if (WebInspector.targetManager.targets().length > 1)
+ this._showAllMessagesCheckbox.element.classList.toggle("hidden", false);
},
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698