Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Side by Side Diff: Source/devtools/front_end/console/ConsoleView.js

Issue 407723002: DevTools: [Console] "Show all messages" checkbox is visible only if a few targets are available (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address vsevik's comment Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 this._currentGroup = this._topGroup; 105 this._currentGroup = this._topGroup;
106 106
107 this._promptElement = this._messagesElement.createChild("div", "source-code" ); 107 this._promptElement = this._messagesElement.createChild("div", "source-code" );
108 this._promptElement.id = "console-prompt"; 108 this._promptElement.id = "console-prompt";
109 this._promptElement.spellcheck = false; 109 this._promptElement.spellcheck = false;
110 110
111 this._showAllMessagesCheckbox = new WebInspector.StatusBarCheckbox(WebInspec tor.UIString("Show all messages")); 111 this._showAllMessagesCheckbox = new WebInspector.StatusBarCheckbox(WebInspec tor.UIString("Show all messages"));
112 this._showAllMessagesCheckbox.inputElement.checked = true; 112 this._showAllMessagesCheckbox.inputElement.checked = true;
113 this._showAllMessagesCheckbox.inputElement.addEventListener("change", this._ updateMessageList.bind(this), false); 113 this._showAllMessagesCheckbox.inputElement.addEventListener("change", this._ updateMessageList.bind(this), false);
114 114
115 if (!WebInspector.experimentsSettings.workersInMainWindow.isEnabled()) 115 this._showAllMessagesCheckbox.element.classList.add("hidden");
116 this._showAllMessagesCheckbox.element.classList.add("hidden");
117 116
118 statusBarElement.appendChild(this._showAllMessagesCheckbox.element); 117 statusBarElement.appendChild(this._showAllMessagesCheckbox.element);
119 118
120 this._registerShortcuts(); 119 this._registerShortcuts();
121 120
122 this._messagesElement.addEventListener("contextmenu", this._handleContextMen uEvent.bind(this), false); 121 this._messagesElement.addEventListener("contextmenu", this._handleContextMen uEvent.bind(this), false);
123 WebInspector.settings.monitoringXHREnabled.addChangeListener(this._monitorin gXHREnabledSettingChanged, this); 122 WebInspector.settings.monitoringXHREnabled.addChangeListener(this._monitorin gXHREnabledSettingChanged, this);
124 123
125 this._linkifier = new WebInspector.Linkifier(); 124 this._linkifier = new WebInspector.Linkifier();
126 125
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 return 16; 196 return 16;
198 }, 197 },
199 198
200 /** 199 /**
201 * @param {!WebInspector.Target} target 200 * @param {!WebInspector.Target} target
202 */ 201 */
203 targetAdded: function(target) 202 targetAdded: function(target)
204 { 203 {
205 this._viewport.invalidate(); 204 this._viewport.invalidate();
206 target.runtimeModel.executionContexts().forEach(this._executionContextCr eated, this); 205 target.runtimeModel.executionContexts().forEach(this._executionContextCr eated, this);
206 if (WebInspector.targetManager.targets().length > 1)
207 this._showAllMessagesCheckbox.element.classList.toggle("hidden", fal se);
207 }, 208 },
208 209
209 /** 210 /**
210 * @param {!WebInspector.Target} target 211 * @param {!WebInspector.Target} target
211 */ 212 */
212 targetRemoved: function(target) 213 targetRemoved: function(target)
213 { 214 {
214 this._clearExecutionContextsForTarget(target); 215 this._clearExecutionContextsForTarget(target);
215 }, 216 },
216 217
(...skipping 998 matching lines...) Expand 10 before | Expand all | Expand 10 after
1215 WebInspector.ConsoleView.ShowConsoleActionDelegate.prototype = { 1216 WebInspector.ConsoleView.ShowConsoleActionDelegate.prototype = {
1216 /** 1217 /**
1217 * @return {boolean} 1218 * @return {boolean}
1218 */ 1219 */
1219 handleAction: function() 1220 handleAction: function()
1220 { 1221 {
1221 WebInspector.console.show(); 1222 WebInspector.console.show();
1222 return true; 1223 return true;
1223 } 1224 }
1224 } 1225 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698