clean up code at crypto folder.

clean up code at crypto folder.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284547

[rucifer1217, 2014-07-19 12:55:50]

please review this code.

[agl, 2014-07-21 13:36:10]

One nit, otherwise good, thanks!

https://codereview.chromium.org/407713002/diff/1/crypto/p224.cc
File crypto/p224.cc (right):

https://codereview.chromium.org/407713002/diff/1/crypto/p224.cc#newcode84
crypto/p224.cc:84: static const uint32 kTwo31p3 = (1u << 31) + (1u << 3);
I think this is worse because it's really writing 2^31 etc, which is  written
very tightly in math notation.

[rucifer1217, 2014-07-21 16:28:11]

revert code around 84line at p224.cc

https://codereview.chromium.org/407713002/diff/1/crypto/p224.cc
File crypto/p224.cc (right):

https://codereview.chromium.org/407713002/diff/1/crypto/p224.cc#newcode84
crypto/p224.cc:84: static const uint32 kTwo31p3 = (1u << 31) + (1u << 3);
On 2014/07/21 13:36:10, agl wrote:
> I think this is worse because it's really writing 2^31 etc, which is  written
> very tightly in math notation.
yes, your opinion is right. i will revert code.

[agl, 2014-07-21 16:39:58]

lgtm

[agl, 2014-07-21 16:40:06]

The CQ bit was checked by agl@chromium.org

[commit-bot: I haz the power, 2014-07-21 16:41:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rucifer1217@gmail.com/407713002/20001

[rucifer1217, 2014-07-21 16:42:03]

On 2014/07/21 16:39:58, agl wrote:
> lgtm

thank you~

[commit-bot: I haz the power, 2014-07-21 20:55:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-22 00:09:32]

Change committed as 284547