Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 407693003: Always show SSL error code at bottom of interstitial (Closed)

Created:
6 years, 5 months ago by felt
Modified:
6 years, 5 months ago
Reviewers:
Bernhard Bauer, agl
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Always show SSL error code at bottom of interstitial Previously, the SSL interstitial only displayed this for the non-overridable pages. Now it displays it for all SSL errors. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284528

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/browser/resources/ssl/interstitial_v2.js View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
felt
PTAL. agl@, you requested this -- sorry to not get to it sooner.
6 years, 5 months ago (2014-07-19 01:21:39 UTC) #1
Bernhard Bauer
lgtm
6 years, 5 months ago (2014-07-21 08:59:35 UTC) #2
agl
On Fri, Jul 18, 2014 at 6:21 PM, <felt@chromium.org> wrote: > Message: > PTAL. agl@, ...
6 years, 5 months ago (2014-07-21 11:03:38 UTC) #3
felt
The CQ bit was checked by felt@chromium.org
6 years, 5 months ago (2014-07-21 15:04:05 UTC) #4
felt
The CQ bit was unchecked by felt@chromium.org
6 years, 5 months ago (2014-07-21 15:04:32 UTC) #5
felt
On 2014/07/21 15:04:05, felt wrote: > The CQ bit was checked by mailto:felt@chromium.org agl for ...
6 years, 5 months ago (2014-07-21 15:05:30 UTC) #6
agl
lgtm
6 years, 5 months ago (2014-07-21 15:17:52 UTC) #7
felt
The CQ bit was checked by felt@chromium.org
6 years, 5 months ago (2014-07-21 15:28:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/407693003/1
6 years, 5 months ago (2014-07-21 15:29:40 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 18:47:38 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 19:11:10 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/173120)
6 years, 5 months ago (2014-07-21 19:11:11 UTC) #12
felt
The CQ bit was checked by felt@chromium.org
6 years, 5 months ago (2014-07-21 22:47:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/407693003/1
6 years, 5 months ago (2014-07-21 22:50:13 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 22:55:35 UTC) #15
Message was sent while issue was closed.
Change committed as 284528

Powered by Google App Engine
This is Rietveld 408576698