Fix .d file outputs, add support for asserting outputs.

Fix .d file outputs, add support for asserting outputs.

Fixes .d file generation by putting the first output file name as the
destination file, rather than the .d file itself.

Adds support for asserting that given files are in the output. This allows
the user of the build tool to assume that certain output files will be
generated while providing a way to catch errors.

[Nico, 2014-07-20 22:30:47]

Looks pretty good, but you probably need to update build_unittest.py with the
new expected output name. And maybe you can add some test for -a while you're
there.

https://codereview.chromium.org/407693002/diff/40001/grit/tool/build.py
File grit/tool/build.py (right):

https://codereview.chromium.org/407693002/diff/40001/grit/tool/build.py#newco...
grit/tool/build.py:409: self.output_directory, outputs[0].GetFilename()),
depdir)
self.output_directory is out/Release in practice, yes? (Looking at the -o docs
above, that seems to be true.)

[brettw, 2014-07-21 17:01:14]

PTAL

https://codereview.chromium.org/407693002/diff/40001/grit/tool/build.py
File grit/tool/build.py (right):

https://codereview.chromium.org/407693002/diff/40001/grit/tool/build.py#newco...
grit/tool/build.py:409: self.output_directory, outputs[0].GetFilename()),
depdir)
On 2014/07/20 22:30:47, Nico (away) wrote:
> self.output_directory is out/Release in practice, yes? (Looking at the -o docs
> above, that seems to be true.)

Yes. This is technically unnecessary in the GN build since the current directory
is out/Release. If this was used in GYP or some similar system, the cd for
running the script would be different than the cd of the build system, so its
necessary to specify it manually.

[Nico, 2014-07-21 18:09:25]

lgtm if tests pass ( https://code.google.com/p/grit-i18n/wiki/RegressionTestPlan
– `grit.py unit`)

https://codereview.chromium.org/407693002/diff/60001/grit/tool/build.py
File grit/tool/build.py (right):

https://codereview.chromium.org/407693002/diff/60001/grit/tool/build.py#newco...
grit/tool/build.py:360: asserted = sorted([os.path.abspath(i) for i in
assert_output_files])
so asserted_output_files is relative to the cwd, but the actual output files are
relative to output_directory?

[brettw, 2014-07-21 19:51:53]

https://codereview.chromium.org/407693002/diff/60001/grit/tool/build.py
File grit/tool/build.py (right):

https://codereview.chromium.org/407693002/diff/60001/grit/tool/build.py#newco...
grit/tool/build.py:360: asserted = sorted([os.path.abspath(i) for i in
assert_output_files])
On 2014/07/21 18:09:25, Nico (away) wrote:
> so asserted_output_files is relative to the cwd, but the actual output files
are
> relative to output_directory?

Yes, like all other inputs, they're relative to the current directory.