Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 407663002: Adding lib32ncurses5-dev to install-builds-deps.sh (Closed)

Created:
6 years, 5 months ago by bradn
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Adding lib32ncurses5-dev to install-builds-deps.sh This library is required to be build tui mode support into nacl gdb. BUG=https://code.google.com/p/chromium/issues/detail?id=391170 TEST=local + bots R=dyen@chromium.org,uekawa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284840

Patch Set 1 #

Patch Set 2 : reflow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/install-build-deps.sh View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
bradn
6 years, 5 months ago (2014-07-19 00:15:17 UTC) #1
David Yen
lgtm
6 years, 5 months ago (2014-07-22 21:08:20 UTC) #2
bradn
The CQ bit was checked by bradnelson@google.com
6 years, 5 months ago (2014-07-22 21:33:46 UTC) #3
bradn
The CQ bit was unchecked by bradnelson@google.com
6 years, 5 months ago (2014-07-22 21:33:56 UTC) #4
bradn
The CQ bit was checked by bradnelson@google.com
6 years, 5 months ago (2014-07-22 21:34:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/407663002/20001
6 years, 5 months ago (2014-07-22 21:35:40 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 21:35:41 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-22 21:35:41 UTC) #8
noelallen1
lgtm
6 years, 5 months ago (2014-07-22 22:53:20 UTC) #9
bradn
The CQ bit was checked by bradnelson@google.com
6 years, 5 months ago (2014-07-22 22:58:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/407663002/20001
6 years, 5 months ago (2014-07-22 23:00:44 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 02:25:13 UTC) #12
Message was sent while issue was closed.
Change committed as 284840

Powered by Google App Engine
This is Rietveld 408576698