Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 407653005: Set tls_client_cert_optional in net/.../testserver.py. (Closed)

Created:
6 years, 5 months ago by pneubeck (no reviews)
Modified:
6 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Set tls_client_cert_optional in net/.../testserver.py. Before this value wasn't set at all leading to crashes of the test server if tsls_client_auth was enabled. BUG=NONE TBR=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284431

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M net/tools/testserver/testserver.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
pneubeck (no reviews)
6 years, 5 months ago (2014-07-21 08:44:45 UTC) #1
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-21 08:44:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/407653005/1
6 years, 5 months ago (2014-07-21 08:45:16 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 14:22:51 UTC) #4
pneubeck (no reviews)
The CQ bit was unchecked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-21 15:20:34 UTC) #5
pneubeck (no reviews)
Committed patchset #1 manually as r284431 (presubmit successful).
6 years, 5 months ago (2014-07-21 15:22:45 UTC) #6
Ryan Sleevi
Note, LGTM, but my comment on the original CL about splitting this out was so ...
6 years, 5 months ago (2014-07-21 18:30:21 UTC) #7
pneubeck (no reviews)
6 years, 5 months ago (2014-07-21 18:39:23 UTC) #8
Message was sent while issue was closed.
On 2014/07/21 18:30:21, Ryan Sleevi wrote:
> Note, LGTM, but my comment on the original CL about splitting this out was so
> that you could file a bug and actually document what the behaviour was.
> 
> Considering that we largely (weren't) getting crashes in testserver.py
suggests
> there's missing details here, which is why I was trying to follow up
separately
> :)
Note, that when I was running that SSLUITest.TestWSSClientCert locally on my
machine it failed exactly because of this missing property.
 
> but thanks for committing.

eieiei. Seems that I was overly optimistically interpreting your
 'testserver.py fix can/should have been its own CL, since it seems unrelated'
:-/
sorry.

Powered by Google App Engine
This is Rietveld 408576698