Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1271)

Issue 407653003: Hook up .d files and outputs to grit (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Hook up .d files and outputs to grit Pull grit 171 to get the new deps fixes required to implement this. This removes the call to grit for querying inputs completely, and enables depfile writing to enable automatic rebuilds when things are out-of-date. Adds a new outputs variable that bypasses querying grit for outputs. This will assert that the given files exist in grit. This version allows outputs to be empty in which case it will revert to the old dynamic behavior. I'm going to land this with just the worst cases fixed to make landing easier. Then followup with converting the rest of the grit targets and removing the dynamic option. R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284705

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 8

Patch Set 4 : Review comments + grit pull #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -25 lines) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A build/secondary/tools/grit/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 1 2 4 chunks +54 lines, -24 lines 0 comments Download
A build/secondary/tools/grit/stamp_grit_sources.py View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/BUILD.gn View 1 2 2 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
This requires a grit roll first.
6 years, 5 months ago (2014-07-21 17:22:00 UTC) #1
viettrungluu
https://codereview.chromium.org/407653003/diff/40001/build/secondary/tools/grit/stamp_grit_sources.py File build/secondary/tools/grit/stamp_grit_sources.py (right): https://codereview.chromium.org/407653003/diff/40001/build/secondary/tools/grit/stamp_grit_sources.py#newcode1 build/secondary/tools/grit/stamp_grit_sources.py:1: # Copyright 2014 The Chromium Authors. All rights reserved. ...
6 years, 5 months ago (2014-07-21 19:43:18 UTC) #2
brettw
https://codereview.chromium.org/407653003/diff/40001/build/secondary/tools/grit/stamp_grit_sources.py File build/secondary/tools/grit/stamp_grit_sources.py (right): https://codereview.chromium.org/407653003/diff/40001/build/secondary/tools/grit/stamp_grit_sources.py#newcode1 build/secondary/tools/grit/stamp_grit_sources.py:1: # Copyright 2014 The Chromium Authors. All rights reserved. ...
6 years, 5 months ago (2014-07-21 20:11:19 UTC) #3
viettrungluu
lgtm
6 years, 5 months ago (2014-07-21 20:22:21 UTC) #4
brettw
6 years, 5 months ago (2014-07-22 16:37:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r284705.

Powered by Google App Engine
This is Rietveld 408576698