Mojo: In Debug builds, log when a race condition in user code is likely observed.

Mojo: In Debug builds, log when a race condition in user code is likely observed.

Probably, we should also do something (assert/DCHECK) in the bindings
code too, but I'll do that separately.

R=darin@chromium.org
BUG=389666
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284934

[viettrungluu, 2014-07-22 18:27:27]

ping

[darin (slow to review), 2014-07-22 19:13:20]

LGTM

Do you want to use NOTREACHED instead to produce a stack trace?

[viettrungluu, 2014-07-22 21:07:06]

On 2014/07/22 19:13:20, darin wrote:
> LGTM
> 
> Do you want to use NOTREACHED instead to produce a stack trace?

I added an appropriate CHECK in the bindings code already, where it's definitely
known to be a bug. Adding it here would make it hard to test this code....

[darin (slow to review), 2014-07-22 21:27:28]

OK


On Tue, Jul 22, 2014 at 2:07 PM, <viettrungluu@chromium.org> wrote:

> On 2014/07/22 19:13:20, darin wrote:
>
>> LGTM
>>
>
>  Do you want to use NOTREACHED instead to produce a stack trace?
>>
>
> I added an appropriate CHECK in the bindings code already, where it's
> definitely
> known to be a bug. Adding it here would make it hard to test this code....
>
> https://codereview.chromium.org/407643002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[viettrungluu, 2014-07-23 15:56:59]

Committed patchset #1 manually as r284934 (presubmit successful).