Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 407633002: Revert of [Telemetry] Fix a flake in android browser finder. (Closed)

Created:
6 years, 5 months ago by tonyg
Modified:
6 years, 5 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Fix a flake in android browser finder. (https://codereview.chromium.org/394423002/) Reason for revert: BUG=395228 Original issue's description: > [Telemetry] Fix a flake in android browser finder. > > Traceback (most recent call last): > File "tools/perf/../telemetry/telemetry/decorators.py", line 50, in wrapper > func(*args, **kwargs) > File "/b/build/slave/Android_Tests/build/src/tools/perf/benchmarks/benchmark_unittest.py", line 51, in BenchmarkSmokeTest > self.assertEqual(0, SinglePageBenchmark().Run(options), > File "tools/perf/../telemetry/telemetry/benchmark.py", line 84, in Run > results = page_runner.Run(test, ps, expectations, args) > File "tools/perf/../telemetry/telemetry/page/page_runner.py", line 346, in Run > possible_browser = browser_finder.FindBrowser(finder_options) > File "tools/perf/../telemetry/telemetry/decorators.py", line 26, in Cacher > cache[key] = obj(*args, **kwargs) > File "tools/perf/../telemetry/telemetry/core/browser_finder.py", line 73, in FindBrowser > curr_browsers = finder.FindAllAvailableBrowsers(options) > File "tools/perf/../telemetry/telemetry/core/backends/chrome/android_browser_finder.py", line 214, in FindAllAvailableBrowsers > pids = [p.pid for p in psutil.process_iter() if 'adb' in p.name] > File "/usr/lib/python2.7/dist-packages/psutil/__init__.py", line 161, in name > cmdline = self.cmdline > File "/usr/lib/python2.7/dist-packages/psutil/__init__.py", line 188, in cmdline > return self._platform_impl.get_process_cmdline() > File "/usr/lib/python2.7/dist-packages/psutil/_pslinux.py", line 327, in wrapper > raise NoSuchProcess(self.pid, self._process_name) > NoSuchProcess: process no longer exists (pid=13764) > > Observed here: > http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14626/steps/telemetry_perf_unittests/logs/stdio > > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284144 TBR=dtu@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284187

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 2 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tonyg
Created Revert of [Telemetry] Fix a flake in android browser finder.
6 years, 5 months ago (2014-07-18 20:05:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/407633002/1
6 years, 5 months ago (2014-07-18 20:07:38 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 20:09:37 UTC) #3
Message was sent while issue was closed.
Change committed as 284187

Powered by Google App Engine
This is Rietveld 408576698