Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 407583004: New owners for harfbuzz-ng (Closed)

Created:
6 years, 5 months ago by Dominik Röttsches
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

New owners for harfbuzz-ng This is intended to add personell who can do harfbuzz rolls when needed. Bashi and I mostly did them recently, we should be able to commit them after review. R=eae,eseidel,behdad BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284287

Patch Set 1 : More owners #

Patch Set 2 : Adding Emil #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/harfbuzz-ng/OWNERS View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Dominik Röttsches
6 years, 5 months ago (2014-07-18 20:14:19 UTC) #1
eae
You'll need an existing OWNER to approve this, either from third_party/harfbuzz-ng/OWNERS or third_party/OWNERS
6 years, 5 months ago (2014-07-18 20:21:27 UTC) #2
Dominik Röttsches
On 2014/07/18 20:21:27, eae wrote: > You'll need an existing OWNER to approve this, either ...
6 years, 5 months ago (2014-07-18 20:36:13 UTC) #3
behdad_google
lgtm Thanks. I would really appreciate this. There's a problem with my behdad@chromium.org account that ...
6 years, 5 months ago (2014-07-18 21:56:06 UTC) #4
behdad_google
lgtm Thanks. I would really appreciate this. There's a problem with my behdad@chromium.org account that ...
6 years, 5 months ago (2014-07-18 21:56:06 UTC) #5
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 5 months ago (2014-07-18 22:39:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/407583004/40001
6 years, 5 months ago (2014-07-18 22:42:15 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 22:42:15 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-18 22:42:16 UTC) #9
eae
LGTM
6 years, 5 months ago (2014-07-18 22:44:44 UTC) #10
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 5 months ago (2014-07-18 23:00:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/407583004/40001
6 years, 5 months ago (2014-07-18 23:01:58 UTC) #12
cpu_(ooo_6.6-7.5)
lgtm
6 years, 5 months ago (2014-07-19 00:05:06 UTC) #13
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 02:26:14 UTC) #14
Message was sent while issue was closed.
Change committed as 284287

Powered by Google App Engine
This is Rietveld 408576698