Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: media/base/audio_renderer.h

Issue 407583002: Fold AudioRenderer::Stop() into the dtor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments addressed Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/mock_filters.h » ('j') | media/filters/audio_renderer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_renderer.h
diff --git a/media/base/audio_renderer.h b/media/base/audio_renderer.h
index 00a8e7f14ddd84b0163d93d03e9c3a6b63bc40c8..48a548dce8fb05cc59ce350600112702c48192da 100644
--- a/media/base/audio_renderer.h
+++ b/media/base/audio_renderer.h
@@ -23,6 +23,8 @@ class MEDIA_EXPORT AudioRenderer {
typedef base::Callback<void(base::TimeDelta, base::TimeDelta)> TimeCB;
AudioRenderer();
+
+ // Stop all operations and fire all pending callbacks.
virtual ~AudioRenderer();
// Initialize an AudioRenderer with |stream|, executing |init_cb| upon
@@ -75,10 +77,6 @@ class MEDIA_EXPORT AudioRenderer {
// Only valid to call after a successful Initialize() or Flush().
virtual void StartPlaying() = 0;
- // Stop all operations in preparation for being deleted, executing |callback|
- // when complete.
- virtual void Stop(const base::Closure& callback) = 0;
-
// Updates the current playback rate.
//
// TODO(scherkus): Fold into TimeSource API.
« no previous file with comments | « no previous file | media/base/mock_filters.h » ('j') | media/filters/audio_renderer_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698