Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issue 407533002: add upload_dir_contents() and download_dir_contents() to gs_utils.py (Closed)

Created:
6 years, 5 months ago by epoger
Modified:
6 years, 5 months ago
Reviewers:
rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/common.git@master
Visibility:
Public.

Description

add upload_dir_contents() and download_dir_contents() to gs_utils.py (with the ability to set fine-grained ACLs as we need when uploading SKPs) BUG=skia:2618, skia:1942 R=rmistry@google.com Committed: https://skia.googlesource.com/common/+/006b9d4

Patch Set 1 : parity with old_gs_utils.py #

Patch Set 2 : add fine_grained_acl_list #

Total comments: 7

Patch Set 3 : update default predefined_acl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -28 lines) Patch
M py/utils/gs_utils.py View 1 2 14 chunks +262 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
epoger
Patchset 1 achieves parity with https://skia.googlesource.com/buildbot/+/master/slave/skia_slave_scripts/utils/old_gs_utils.py (for these particular methods) Before sending this out for ...
6 years, 5 months ago (2014-07-18 15:11:16 UTC) #1
epoger
Ravi- please review at patchset 2. https://codereview.chromium.org/407533002/diff/20001/py/utils/gs_utils.py File py/utils/gs_utils.py (right): https://codereview.chromium.org/407533002/diff/20001/py/utils/gs_utils.py#newcode140 py/utils/gs_utils.py:140: except BotoServerError, e: ...
6 years, 5 months ago (2014-07-18 15:48:19 UTC) #2
rmistry
https://codereview.chromium.org/407533002/diff/20001/py/utils/gs_utils.py File py/utils/gs_utils.py (right): https://codereview.chromium.org/407533002/diff/20001/py/utils/gs_utils.py#newcode57 py/utils/gs_utils.py:57: CANNED_ACL_PUBLIC_READ_WRITE = 'public-read-write' Nit: Change the above to only ...
6 years, 5 months ago (2014-07-18 16:55:07 UTC) #3
epoger
Thanks, Ravi... https://codereview.chromium.org/407533002/diff/20001/py/utils/gs_utils.py File py/utils/gs_utils.py (right): https://codereview.chromium.org/407533002/diff/20001/py/utils/gs_utils.py#newcode57 py/utils/gs_utils.py:57: CANNED_ACL_PUBLIC_READ_WRITE = 'public-read-write' On 2014/07/18 16:55:07, rmistry ...
6 years, 5 months ago (2014-07-18 17:36:19 UTC) #4
rmistry
LGTM
6 years, 5 months ago (2014-07-18 17:38:41 UTC) #5
epoger
6 years, 5 months ago (2014-07-18 17:41:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r006b9d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698