Issue 407513002: Revert of Bypass the favicon_service when importing favicons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 407513002: Revert of Bypass the favicon_service when importing favicons. (Closed)

Created:
6 years, 5 months ago by jif

Modified:
6 years, 5 months ago

Reviewers:
gab, jif-google, blundell

CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Bypass the favicon_service when importing favicons. (https://codereview.chromium.org/375613002/) Reason for revert: There's a better approach. Original issue's description: > Bypass the favicon_service when importing favicons. > > BUG=391795 > TBR=gab > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284045 TBR=blundell@chromium.org,jif@google.com,gab@chromium.org NOTREECHECKS=true NOTRY=true BUG=391795 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284092

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -21 lines)			Patch
M	chrome/browser/favicon/favicon_service.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/favicon/favicon_service.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/history/history_service.h	View	2 chunks	+6 lines, -8 lines	0 comments	Download
M	chrome/browser/history/history_service.cc	View	2 chunks	+7 lines, -9 lines	0 comments	Download
M	chrome/browser/importer/profile_writer.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

jif

Created Revert of Bypass the favicon_service when importing favicons.

6 years, 5 months ago (2014-07-18 14:15:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jif@chromium.org/407513002/1

6 years, 5 months ago (2014-07-18 14:17:57 UTC) #2

Message was sent while issue was closed.

Change committed as 284092