Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 407493004: Revert of Revert of Migrate accessibility from RenderView to RenderFrame. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 205f3fcd6bae5a36b31577dbe5ea8d4bd3cc4016..ad9fffb58881488ee7895c078cb31e83bcbbfc2d 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -651,9 +651,8 @@
if (!host)
return static_cast<gfx::NativeViewAccessible>(NULL);
HWND hwnd = host->GetAcceleratedWidget();
-
- CreateBrowserAccessibilityManagerIfNeeded();
- BrowserAccessibilityManager* manager = GetBrowserAccessibilityManager();
+ BrowserAccessibilityManager* manager =
+ host_->GetOrCreateRootBrowserAccessibilityManager();
if (manager)
return manager->GetRoot()->ToBrowserAccessibilityWin();
#endif
@@ -1043,8 +1042,10 @@
#if defined(OS_WIN)
void RenderWidgetHostViewAura::SetParentNativeViewAccessible(
gfx::NativeViewAccessible accessible_parent) {
- if (GetBrowserAccessibilityManager()) {
- GetBrowserAccessibilityManager()->ToBrowserAccessibilityManagerWin()
+ BrowserAccessibilityManager* manager =
+ host_->GetRootBrowserAccessibilityManager();
+ if (manager) {
+ manager->ToBrowserAccessibilityManagerWin()
->set_parent_iaccessible(accessible_parent);
}
}
@@ -1191,22 +1192,21 @@
: INPUT_EVENT_ACK_STATE_NOT_CONSUMED;
}
-void RenderWidgetHostViewAura::CreateBrowserAccessibilityManagerIfNeeded() {
+BrowserAccessibilityManager*
+RenderWidgetHostViewAura::CreateBrowserAccessibilityManager(
+ BrowserAccessibilityDelegate* delegate) {
+ BrowserAccessibilityManager* manager = NULL;
#if defined(OS_WIN)
- if (!GetBrowserAccessibilityManager()) {
- gfx::NativeViewAccessible accessible_parent =
- host_->GetParentNativeViewAccessible();
- SetBrowserAccessibilityManager(new BrowserAccessibilityManagerWin(
- legacy_render_widget_host_HWND_, accessible_parent,
- BrowserAccessibilityManagerWin::GetEmptyDocument(), host_));
- }
+ gfx::NativeViewAccessible accessible_parent =
+ host_->GetParentNativeViewAccessible();
+ manager = new BrowserAccessibilityManagerWin(
+ legacy_render_widget_host_HWND_, accessible_parent,
+ BrowserAccessibilityManagerWin::GetEmptyDocument(), delegate);
#else
- if (!GetBrowserAccessibilityManager()) {
- SetBrowserAccessibilityManager(
- BrowserAccessibilityManager::Create(
- BrowserAccessibilityManager::GetEmptyDocument(), host_));
- }
-#endif
+ manager = BrowserAccessibilityManager::Create(
+ BrowserAccessibilityManager::GetEmptyDocument(), delegate);
+#endif
+ return manager;
}
gfx::GLSurfaceHandle RenderWidgetHostViewAura::GetCompositingSurface() {
@@ -2048,7 +2048,8 @@
host_->SetInputMethodActive(false);
}
- BrowserAccessibilityManager* manager = GetBrowserAccessibilityManager();
+ BrowserAccessibilityManager* manager =
+ host_->GetRootBrowserAccessibilityManager();
if (manager)
manager->OnWindowFocused();
} else if (window_ == lost_focus) {
@@ -2064,7 +2065,8 @@
if (overscroll_controller_)
overscroll_controller_->Cancel();
- BrowserAccessibilityManager* manager = GetBrowserAccessibilityManager();
+ BrowserAccessibilityManager* manager =
+ host_->GetRootBrowserAccessibilityManager();
if (manager)
manager->OnWindowBlurred();
@@ -2310,7 +2312,7 @@
BrowserAccessibilityManagerWin* manager =
static_cast<BrowserAccessibilityManagerWin*>(
- GetBrowserAccessibilityManager());
+ host_->GetRootBrowserAccessibilityManager());
if (manager)
manager->SetAccessibleHWND(legacy_render_widget_host_HWND_);
}

Powered by Google App Engine
This is Rietveld 408576698