Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Issue 407493003: [oilpan]: Ensure context destroyed is propagated to parent. (Closed)

Created:
6 years, 5 months ago by wibling-chromium
Modified:
6 years, 5 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

[oilpan]: Ensure context destroyed is propagated to parent. With my previous fix for some of the websocket crashes I didn't propagated the fact that the context was destroyed to the base class. This resulted in some cases where we called unobserveContext with where the lifecycle context was actually dead, crashing since further down the stack since it ended up calling on zapped memory. This change should fix that. R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/modules/websockets/NewWebSocketChannelImpl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
wibling-chromium
6 years, 5 months ago (2014-07-18 08:44:14 UTC) #1
Mads Ager (chromium)
lgtm
6 years, 5 months ago (2014-07-18 08:58:21 UTC) #2
tkent
lgtm
6 years, 5 months ago (2014-07-18 09:06:45 UTC) #3
wibling-chromium
The CQ bit was checked by wibling@chromium.org
6 years, 5 months ago (2014-07-18 09:28:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wibling@chromium.org/407493003/1
6 years, 5 months ago (2014-07-18 09:29:14 UTC) #5
haraken
LGTM
6 years, 5 months ago (2014-07-18 09:31:05 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-18 10:46:01 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 11:46:47 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17705)
6 years, 5 months ago (2014-07-18 11:46:48 UTC) #9
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 5 months ago (2014-07-18 13:32:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wibling@chromium.org/407493003/1
6 years, 5 months ago (2014-07-18 13:33:08 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 13:33:38 UTC) #12
Message was sent while issue was closed.
Change committed as 178435

Powered by Google App Engine
This is Rietveld 408576698