Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 407493002: Revert of Migrate accessibility from RenderView to RenderFrame. (Closed)

Created:
6 years, 5 months ago by Mike West
Modified:
6 years, 5 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, nasko+codewatch_chromium.org, sievers+watch_chromium.org, yukishiino+watch_chromium.org, dmazzoni+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, creis+watch_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, plundblad+watch_chromium.org, dtseng+watch_chromium.org, danakj+watch_chromium.org, James Su
Visibility:
Public.

Description

Revert of Migrate accessibility from RenderView to RenderFrame. (https://codereview.chromium.org/273423004/) Reason for revert: Speculative revert to fix XP bots. XP bots started crashing http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32011 and http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34677 This CL is the most suspicious in the range. If it doesn't fix the bots, I'll unrevert it. Original issue's description: > Migrate accessibility from RenderView to RenderFrame and RVH to RFH. > > In preparation for out-of-process iframes, move almost all accessibility > functionality from RenderView to RenderFrame, and from RVHI and RWHI > to RFHI. > > In addition, the accessibility mode is moved to WebContents, and changing > the mode triggers changing it on all frames. > > BUG=368298 > R=jam@chromium.org, kenrb@chromium.org, nick@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283994 TBR=dmazzoni@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284032

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+846 lines, -1366 lines) Patch
M chrome/browser/chrome_browser_application_mac.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/automation/automation_apitest.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/automation_internal/automation_internal_api.cc View 6 chunks +37 lines, -35 lines 0 comments Download
D content/browser/accessibility/#browser_accessibility_manager.cc# View 1 chunk +0 lines, -401 lines 0 comments Download
M content/browser/accessibility/accessibility_mode_browsertest.cc View 4 chunks +28 lines, -20 lines 0 comments Download
M content/browser/accessibility/accessibility_mode_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/accessibility_mode_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/accessibility_tree_formatter.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/accessibility/accessibility_ui.cc View 4 chunks +29 lines, -16 lines 0 comments Download
M content/browser/accessibility/android_hit_testing_browsertest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 2 chunks +2 lines, -8 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.h View 2 chunks +3 lines, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.cc View 2 chunks +1 line, -5 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_state_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_state_impl.cc View 4 chunks +35 lines, -15 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 3 chunks +12 lines, -9 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 2 chunks +1 line, -12 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 3 chunks +0 lines, -20 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 6 chunks +1 line, -67 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 6 chunks +0 lines, -190 lines 0 comments Download
M content/browser/renderer_host/legacy_render_widget_host_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/legacy_render_widget_host_win.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 4 chunks +37 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 7 chunks +73 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.h View 2 chunks +1 line, -9 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.cc View 2 chunks +1 line, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 9 chunks +53 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 6 chunks +107 lines, -18 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +17 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 6 chunks +22 lines, -24 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 4 chunks +15 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +16 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 6 chunks +44 lines, -20 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 8 chunks +5 lines, -33 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 14 chunks +9 lines, -107 lines 0 comments Download
D content/common/accessibility_mode_enums.h View 1 chunk +0 lines, -38 lines 0 comments Download
M content/common/frame_message_enums.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/frame_messages.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/common/view_message_enums.h View 1 chunk +30 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 3 chunks +8 lines, -0 lines 0 comments Download
M content/public/browser/render_frame_host.h View 2 chunks +0 lines, -9 lines 0 comments Download
M content/public/browser/render_widget_host.h View 1 chunk +36 lines, -0 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +0 lines, -12 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility.h View 5 chunks +8 lines, -9 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_browsertest.cc View 9 chunks +9 lines, -10 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_complete.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_complete.cc View 5 chunks +12 lines, -6 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_focus_only.h View 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_focus_only.cc View 6 chunks +13 lines, -9 lines 0 comments Download
M content/renderer/render_frame_impl.h View 8 chunks +0 lines, -30 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 6 chunks +2 lines, -38 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 chunk +21 lines, -21 lines 0 comments Download
M content/renderer/render_view_impl.h View 7 chunks +21 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 10 chunks +38 lines, -13 lines 0 comments Download
M content/renderer/render_view_impl_params.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/render_view_impl_params.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/test/accessibility_browser_test_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/test/accessibility_browser_test_utils.cc View 4 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mike West
Created Revert of Migrate accessibility from RenderView to RenderFrame.
6 years, 5 months ago (2014-07-18 07:38:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/407493002/1
6 years, 5 months ago (2014-07-18 07:39:22 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 07:39:23 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-18 07:39:24 UTC) #4
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 5 months ago (2014-07-18 07:40:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/407493002/1
6 years, 5 months ago (2014-07-18 07:41:12 UTC) #6
commit-bot: I haz the power
Change committed as 284032
6 years, 5 months ago (2014-07-18 07:42:32 UTC) #7
Mike West
6 years, 5 months ago (2014-07-18 12:28:34 UTC) #8
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/407493004/ by mkwst@chromium.org.

The reason for reverting is: Reverting the revert. This didn't break the tree;
it's still broken without the patch. :(

Sorry for the noise!.

Powered by Google App Engine
This is Rietveld 408576698