Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 407443008: Fix cert DB usage in PolicyCertVerifier test. (Closed)

Created:
6 years, 5 months ago by pneubeck (no reviews)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix cert DB usage in PolicyCertVerifier test. - Replaces ScopedTestNSSDB by ScopedTestNSSChromeOSUser, which is the choice for ChromeOS. - Removes the deprecated net::NSSCertDatabase::GetInstance() call. - Changes the build target from brower_test to unit_test, as originally intended. BUG=329735, 210525 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -250 lines) Patch
D chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc View 1 chunk +0 lines, -233 lines 0 comments Download
A + chrome/browser/chromeos/policy/policy_cert_verifier_unittest.cc View 4 chunks +18 lines, -16 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pneubeck (no reviews)
Julian, ptal. Jochen, need your lgtm for the gyp changes.
6 years, 5 months ago (2014-07-18 12:29:15 UTC) #1
jochen (gone - plz use gerrit)
gyp lgtm
6 years, 5 months ago (2014-07-18 12:30:45 UTC) #2
pastarmovj
lgtm
6 years, 5 months ago (2014-07-18 12:38:01 UTC) #3
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 5 months ago (2014-07-18 12:42:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/407443008/1
6 years, 5 months ago (2014-07-18 12:43:06 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 14:29:16 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 16:11:55 UTC) #7
Message was sent while issue was closed.
Change committed as 284112

Powered by Google App Engine
This is Rietveld 408576698