Don't drop all children when changing Android root layer.

Don't drop all children when changing Android root layer.

Unlike when this method was originally written, there can now be a
second child, a readback layer.  If the root layer happens to change
while a readback is active, it will never complete, hanging the
rendering.

NOTRY=true
BUG=386337
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284164

[aelias_OOO_until_Jul13, 2014-07-18 01:39:55]

PTAL.

[no sievers, 2014-07-18 17:59:44]

that explains it. LGTM

https://codereview.chromium.org/407433002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/compositor_impl_android.h (right):

https://codereview.chromium.org/407433002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/compositor_impl_android.h:135:
scoped_refptr<cc::Layer> root_layer_;
nit: how about a comment saying that root_layer_ is the persistent internal root
node, and subroot_layer_ is the one that the compositor client has attached?

[aelias_OOO_until_Jul13, 2014-07-18 18:25:15]

https://codereview.chromium.org/407433002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/compositor_impl_android.h (right):

https://codereview.chromium.org/407433002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/compositor_impl_android.h:135:
scoped_refptr<cc::Layer> root_layer_;
On 2014/07/18 17:59:43, sievers wrote:
> nit: how about a comment saying that root_layer_ is the persistent internal
root
> node, and subroot_layer_ is the one that the compositor client has attached?

Done.

[aelias_OOO_until_Jul13, 2014-07-18 18:25:31]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2014-07-18 18:27:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aelias@chromium.org/407433002/20001

[commit-bot: I haz the power, 2014-07-18 18:30:10]

Change committed as 284164