Issue 407413002: Remove confirmation from git cl land.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 407413002: Remove confirmation from git cl land. (Closed)

Created:
6 years, 5 months ago by M-A Ruel

Modified:
6 years, 5 months ago

Reviewers:
ghost stip (do not use)

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Project:
tools

Visibility:
Public.

More Reviews

Description

Remove confirmation from git cl land. It serves no purpose, and it's annoying when the presubmit checks take more than 2-3 seconds because I always switch off to another window, so I come back minutes later seeing this prompt waiting for me. R=stip@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=285071

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	git_cl.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	tests/git_cl_test.py	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/407413002/1

6 years, 5 months ago (2014-07-23 23:02:40 UTC) #4

Message was sent while issue was closed.

Change committed as 285071

Expand Messages | Collapse Messages