Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 4074: Fix some XSS test by fixing an improperly merged file and falling back on... (Closed)

Created:
12 years, 3 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix some XSS test by fixing an improperly merged file and falling back on the common/ versions of tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -110 lines) Patch
D webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D webkit/data/layout_test_results/v8/LayoutTests/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
M webkit/pending/SecurityOrigin.cpp View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 2 (0 generated)
Evan Martin
VICTORY http://codereview.chromium.org/4074/diff/1/2 File webkit/pending/SecurityOrigin.cpp (right): http://codereview.chromium.org/4074/diff/1/2#newcode117 Line 117: { This looks funny, but it's what ...
12 years, 3 months ago (2008-09-25 00:56:10 UTC) #1
tony
12 years, 3 months ago (2008-09-25 00:58:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698