Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 407353002: [usb_gadget p02] Basic USB device implementation. (Closed)

Created:
6 years, 5 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[usb_gadget p02] Basic USB device implementation. The gadget.Gadget class implements the basic USB control requests required by all devices. It handles common operations like changing the configuration and interface alternatives and fetching descriptors. The device interfaces with a "chip" which is the USB peripheral controller that connects the emulated device to a USB host. BUG=396682 R=rockot@chromium.org,rpaquay@chromium.org,kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285098

Patch Set 1 #

Patch Set 2 : Merged in feedback from the USB descriptors review. #

Patch Set 3 : Fixed copyright text and added specification references. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+717 lines, -0 lines) Patch
A tools/usb_gadget/gadget.py View 1 2 1 chunk +432 lines, -0 lines 0 comments Download
A tools/usb_gadget/gadget_test.py View 1 2 1 chunk +285 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Reilly Grant (use Gerrit)
6 years, 5 months ago (2014-07-22 23:34:40 UTC) #1
Reilly Grant (use Gerrit)
6 years, 5 months ago (2014-07-23 01:02:20 UTC) #2
Ken Rockot(use gerrit already)
Rubber stamp lgtm; I have not fully verified the accuracy of the test expectations, but ...
6 years, 5 months ago (2014-07-23 16:02:50 UTC) #3
Reilly Grant (use Gerrit)
On 2014/07/23 16:02:50, Ken Rockot wrote: > Rubber stamp lgtm; I have not fully verified ...
6 years, 5 months ago (2014-07-23 18:11:16 UTC) #4
Reilly Grant (use Gerrit)
6 years, 5 months ago (2014-07-23 18:11:27 UTC) #5
Reilly Grant (use Gerrit)
The CQ bit was checked by reillyg@chromium.org
6 years, 5 months ago (2014-07-23 18:11:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/407353002/40001
6 years, 5 months ago (2014-07-23 18:13:48 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 22:13:03 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 01:04:34 UTC) #9
Message was sent while issue was closed.
Change committed as 285098

Powered by Google App Engine
This is Rietveld 408576698