Source/core/rendering/style/RenderStyleConstants.h - Issue 40733004: Replace compile flag with runtime check for text-underline-position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/RenderStyleConstants.h

Issue 40733004: Replace compile flag with runtime check for text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Julien's review #2 (rebased) Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/style/RenderStyleConstants.h

diff --git a/Source/core/rendering/style/RenderStyleConstants.h b/Source/core/rendering/style/RenderStyleConstants.h

index b66d8ed5c715ed7bc04d3b243f268d757eef56f1..359bd551eb283e418418e1050823fec1abc45c76 100644

--- a/Source/core/rendering/style/RenderStyleConstants.h

+++ b/Source/core/rendering/style/RenderStyleConstants.h

@@ -377,12 +377,10 @@ enum TextJustify {

TextJustifyAuto, TextJustifyNone, TextJustifyInterWord, TextJustifyDistribute

};

-#if ENABLE(CSS3_TEXT)

enum TextUnderlinePosition {

// FIXME: Implement support for 'under left' and 'under right' values.

TextUnderlinePositionAuto = 0x1, TextUnderlinePositionAlphabetic = 0x2, TextUnderlinePositionUnder = 0x4

};

-#endif // CSS3_TEXT

enum EPageBreak {

PBAUTO, PBALWAYS, PBAVOID