Source/core/rendering/RootInlineBox.h - Issue 40733004: Replace compile flag with runtime check for text-underline-position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RootInlineBox.h

Issue 40733004: Replace compile flag with runtime check for text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Julien's review #2 (rebased) Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RootInlineBox.h

diff --git a/Source/core/rendering/RootInlineBox.h b/Source/core/rendering/RootInlineBox.h

index 53397c4bc8b35050aa415dcb21ef978bde9a4f43..3790532b55d26a443ac69e8d1951ed904b95f570 100644

--- a/Source/core/rendering/RootInlineBox.h

+++ b/Source/core/rendering/RootInlineBox.h

@@ -181,10 +181,8 @@ public:

return InlineFlowBox::logicalBottomLayoutOverflow(lineBottom());

}

-#if ENABLE(CSS3_TEXT)

// Used to calculate the underline offset for TextUnderlinePositionUnder.

float maxLogicalTop() const;

-#endif // CSS3_TEXT

Node* getLogicalStartBoxWithNode(InlineBox*&) const;

Node* getLogicalEndBoxWithNode(InlineBox*&) const;

« no previous file with comments | « Source/core/rendering/InlineTextBox.cpp ('k') | Source/core/rendering/RootInlineBox.cpp » ('j') | no next file with comments »