Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt

Issue 40733004: Replace compile flag with runtime check for text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Julien's review #2 (rebased) Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt
diff --git a/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt b/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt
index 818d0bb359c50ba58bd671db49c6a0334df567c7..17540fa8f8706a51eca40b3047312621c0a565eb 100644
--- a/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt
+++ b/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt
@@ -1,69 +1,69 @@
-Test to make sure -webkit-text-underline-position property returns values properly.
+Test to make sure text-underline-position property returns values properly.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Initial value:
-PASS e.style.getPropertyCSSValue('-webkit-text-underline-position') is null
-FAIL computedStyle.webkitTextUnderlinePosition should be auto (of type string). Was undefined (of type undefined).
-FAIL computedStyle.getPropertyCSSValue('-webkit-text-underline-position').toString() should be [object CSSPrimitiveValue]. Threw exception TypeError: Cannot call method 'toString' of null
-FAIL computedStyle.getPropertyCSSValue('-webkit-text-underline-position').cssText should be auto. Threw exception TypeError: Cannot read property 'cssText' of null
+PASS e.style.getPropertyCSSValue('text-underline-position') is null
+PASS computedStyle.textUnderlinePosition is 'auto'
+PASS computedStyle.getPropertyCSSValue('text-underline-position').toString() is '[object CSSPrimitiveValue]'
+PASS computedStyle.getPropertyCSSValue('text-underline-position').cssText is 'auto'
Value '':
-PASS e.style.getPropertyCSSValue('-webkit-text-underline-position') is null
-FAIL computedStyle.webkitTextUnderlinePosition should be auto (of type string). Was undefined (of type undefined).
-FAIL computedStyle.getPropertyCSSValue('-webkit-text-underline-position').toString() should be [object CSSPrimitiveValue]. Threw exception TypeError: Cannot call method 'toString' of null
-FAIL computedStyle.getPropertyCSSValue('-webkit-text-underline-position').cssText should be auto. Threw exception TypeError: Cannot read property 'cssText' of null
+PASS e.style.getPropertyCSSValue('text-underline-position') is null
+PASS computedStyle.textUnderlinePosition is 'auto'
+PASS computedStyle.getPropertyCSSValue('text-underline-position').toString() is '[object CSSPrimitiveValue]'
+PASS computedStyle.getPropertyCSSValue('text-underline-position').cssText is 'auto'
Initial value (explicit):
-PASS e.style.webkitTextUnderlinePosition is 'initial'
-FAIL e.style.getPropertyCSSValue('-webkit-text-underline-position').toString() should be [object CSSValue]. Threw exception TypeError: Cannot call method 'toString' of null
-FAIL e.style.getPropertyCSSValue('-webkit-text-underline-position').cssText should be initial. Threw exception TypeError: Cannot read property 'cssText' of null
-FAIL computedStyle.webkitTextUnderlinePosition should be auto (of type string). Was undefined (of type undefined).
-FAIL computedStyle.getPropertyCSSValue('-webkit-text-underline-position').toString() should be [object CSSPrimitiveValue]. Threw exception TypeError: Cannot call method 'toString' of null
-FAIL computedStyle.getPropertyCSSValue('-webkit-text-underline-position').cssText should be auto. Threw exception TypeError: Cannot read property 'cssText' of null
+PASS e.style.textUnderlinePosition is 'initial'
+PASS e.style.getPropertyCSSValue('text-underline-position').toString() is '[object CSSValue]'
+PASS e.style.getPropertyCSSValue('text-underline-position').cssText is 'initial'
+PASS computedStyle.textUnderlinePosition is 'auto'
+PASS computedStyle.getPropertyCSSValue('text-underline-position').toString() is '[object CSSPrimitiveValue]'
+PASS computedStyle.getPropertyCSSValue('text-underline-position').cssText is 'auto'
Value 'auto':
-PASS e.style.webkitTextUnderlinePosition is 'auto'
-FAIL e.style.getPropertyCSSValue('-webkit-text-underline-position').toString() should be [object CSSPrimitiveValue]. Threw exception TypeError: Cannot call method 'toString' of null
-FAIL e.style.getPropertyCSSValue('-webkit-text-underline-position').cssText should be auto. Threw exception TypeError: Cannot read property 'cssText' of null
-FAIL computedStyle.webkitTextUnderlinePosition should be auto (of type string). Was undefined (of type undefined).
-FAIL computedStyle.getPropertyCSSValue('-webkit-text-underline-position').toString() should be [object CSSPrimitiveValue]. Threw exception TypeError: Cannot call method 'toString' of null
-FAIL computedStyle.getPropertyCSSValue('-webkit-text-underline-position').cssText should be auto. Threw exception TypeError: Cannot read property 'cssText' of null
+PASS e.style.textUnderlinePosition is 'auto'
+PASS e.style.getPropertyCSSValue('text-underline-position').toString() is '[object CSSPrimitiveValue]'
+PASS e.style.getPropertyCSSValue('text-underline-position').cssText is 'auto'
+PASS computedStyle.textUnderlinePosition is 'auto'
+PASS computedStyle.getPropertyCSSValue('text-underline-position').toString() is '[object CSSPrimitiveValue]'
+PASS computedStyle.getPropertyCSSValue('text-underline-position').cssText is 'auto'
Value 'alphabetic':
-PASS e.style.webkitTextUnderlinePosition is 'alphabetic'
-FAIL e.style.getPropertyCSSValue('-webkit-text-underline-position').toString() should be [object CSSPrimitiveValue]. Threw exception TypeError: Cannot call method 'toString' of null
-FAIL e.style.getPropertyCSSValue('-webkit-text-underline-position').cssText should be alphabetic. Threw exception TypeError: Cannot read property 'cssText' of null
-FAIL computedStyle.webkitTextUnderlinePosition should be alphabetic (of type string). Was undefined (of type undefined).
-FAIL computedStyle.getPropertyCSSValue('-webkit-text-underline-position').toString() should be [object CSSPrimitiveValue]. Threw exception TypeError: Cannot call method 'toString' of null
-FAIL computedStyle.getPropertyCSSValue('-webkit-text-underline-position').cssText should be alphabetic. Threw exception TypeError: Cannot read property 'cssText' of null
+PASS e.style.textUnderlinePosition is 'alphabetic'
+PASS e.style.getPropertyCSSValue('text-underline-position').toString() is '[object CSSPrimitiveValue]'
+PASS e.style.getPropertyCSSValue('text-underline-position').cssText is 'alphabetic'
+PASS computedStyle.textUnderlinePosition is 'alphabetic'
+PASS computedStyle.getPropertyCSSValue('text-underline-position').toString() is '[object CSSPrimitiveValue]'
+PASS computedStyle.getPropertyCSSValue('text-underline-position').cssText is 'alphabetic'
Value 'under':
-PASS e.style.webkitTextUnderlinePosition is 'under'
-FAIL e.style.getPropertyCSSValue('-webkit-text-underline-position').toString() should be [object CSSPrimitiveValue]. Threw exception TypeError: Cannot call method 'toString' of null
-FAIL e.style.getPropertyCSSValue('-webkit-text-underline-position').cssText should be under. Threw exception TypeError: Cannot read property 'cssText' of null
-FAIL computedStyle.webkitTextUnderlinePosition should be under (of type string). Was undefined (of type undefined).
-FAIL computedStyle.getPropertyCSSValue('-webkit-text-underline-position').toString() should be [object CSSPrimitiveValue]. Threw exception TypeError: Cannot call method 'toString' of null
-FAIL computedStyle.getPropertyCSSValue('-webkit-text-underline-position').cssText should be under. Threw exception TypeError: Cannot read property 'cssText' of null
+PASS e.style.textUnderlinePosition is 'under'
+PASS e.style.getPropertyCSSValue('text-underline-position').toString() is '[object CSSPrimitiveValue]'
+PASS e.style.getPropertyCSSValue('text-underline-position').cssText is 'under'
+PASS computedStyle.textUnderlinePosition is 'under'
+PASS computedStyle.getPropertyCSSValue('text-underline-position').toString() is '[object CSSPrimitiveValue]'
+PASS computedStyle.getPropertyCSSValue('text-underline-position').cssText is 'under'
Ancestor inherits values from parent:
-PASS e.style.getPropertyCSSValue('-webkit-text-underline-position') is null
-FAIL computedStyle.webkitTextUnderlinePosition should be under (of type string). Was undefined (of type undefined).
-FAIL computedStyle.getPropertyCSSValue('-webkit-text-underline-position').toString() should be [object CSSPrimitiveValue]. Threw exception TypeError: Cannot call method 'toString' of null
-FAIL computedStyle.getPropertyCSSValue('-webkit-text-underline-position').cssText should be under. Threw exception TypeError: Cannot read property 'cssText' of null
+PASS e.style.getPropertyCSSValue('text-underline-position') is null
+PASS computedStyle.textUnderlinePosition is 'under'
+PASS computedStyle.getPropertyCSSValue('text-underline-position').toString() is '[object CSSPrimitiveValue]'
+PASS computedStyle.getPropertyCSSValue('text-underline-position').cssText is 'under'
Value 'auto alphabetic':
-PASS e.style.getPropertyCSSValue('-webkit-text-underline-position') is null
+PASS e.style.getPropertyCSSValue('text-underline-position') is null
Value 'auto under':
-PASS e.style.getPropertyCSSValue('-webkit-text-underline-position') is null
+PASS e.style.getPropertyCSSValue('text-underline-position') is null
Value 'under under':
-PASS e.style.getPropertyCSSValue('-webkit-text-underline-position') is null
+PASS e.style.getPropertyCSSValue('text-underline-position') is null
Value 'under under under':
-PASS e.style.getPropertyCSSValue('-webkit-text-underline-position') is null
+PASS e.style.getPropertyCSSValue('text-underline-position') is null
PASS successfullyParsed is true

Powered by Google App Engine
This is Rietveld 408576698