Source/core/rendering/RootInlineBox.cpp - Issue 40733004: Replace compile flag with runtime check for text-underline-position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RootInlineBox.cpp

Issue 40733004: Replace compile flag with runtime check for text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed a typo in static function compileUnderlineOffset signature / Rebase Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/RootInlineBox.cpp

diff --git a/Source/core/rendering/RootInlineBox.cpp b/Source/core/rendering/RootInlineBox.cpp

index 589217353b9a849e14db658043c55a083c0325f8..95582690ab3a1e6097aeb4cc777d991c9334e124 100644

--- a/Source/core/rendering/RootInlineBox.cpp

+++ b/Source/core/rendering/RootInlineBox.cpp

@@ -290,14 +290,12 @@ LayoutUnit RootInlineBox::alignBoxesInBlockDirection(LayoutUnit heightOfBlock, G

return heightOfBlock + maxHeight;

}

-#if ENABLE(CSS3_TEXT)

float RootInlineBox::maxLogicalTop() const

{

float maxLogicalTop = 0;

computeMaxLogicalTop(maxLogicalTop);

return maxLogicalTop;

}

-#endif // CSS3_TEXT

LayoutUnit RootInlineBox::beforeAnnotationsAdjustment() const

{