Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js

Issue 40733004: Replace compile flag with runtime check for text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed a typo in static function compileUnderlineOffset signature / Rebase Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt ('k') | LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/style.css » ('j') | LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js
diff --git a/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js b/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js
index a9e1b15786698a20c995eff96dcf9bae1cf503fd..a18322e560ceb0cbb6b05a6c1270218a3307405a 100644
--- a/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js
+++ b/LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js
@@ -16,7 +16,7 @@ function testComputedStyle(propertyJS, propertyCSS, type, value)
shouldBe("computedStyle.getPropertyCSSValue('" + propertyCSS + "').cssText", "'" + value + "'");
}
-description("Test to make sure -webkit-text-underline-position property returns values properly.")
+description("Test to make sure text-underline-position property returns values properly.")
// FIXME: This test tests property values 'auto', 'alphabetic' and 'under'. We don't fully match
// the specification as we don't support [ left | right ] and this is left for another implementation
@@ -30,65 +30,65 @@ testContainer.innerHTML = '<div id="test">hello world</div>';
debug("Initial value:");
e = document.getElementById('test');
-testElementStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", null, '');
-testComputedStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", "[object CSSPrimitiveValue]", "auto");
+testElementStyle("textUnderlinePosition", "text-underline-position", null, '');
+testComputedStyle("textUnderlinePosition", "text-underline-position", "[object CSSPrimitiveValue]", "auto");
debug('');
debug("Value '':");
-e.style.webkitTextUnderlinePosition = '';
-testElementStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", null, '');
-testComputedStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", "[object CSSPrimitiveValue]", "auto");
+e.style.textUnderlinePosition = '';
+testElementStyle("textUnderlinePosition", "text-underline-position", null, '');
+testComputedStyle("textUnderlinePosition", "text-underline-position", "[object CSSPrimitiveValue]", "auto");
debug('');
debug("Initial value (explicit):");
-e.style.webkitTextUnderlinePosition = 'initial';
-testElementStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", "[object CSSValue]", "initial");
-testComputedStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", "[object CSSPrimitiveValue]", "auto");
+e.style.textUnderlinePosition = 'initial';
+testElementStyle("textUnderlinePosition", "text-underline-position", "[object CSSValue]", "initial");
+testComputedStyle("textUnderlinePosition", "text-underline-position", "[object CSSPrimitiveValue]", "auto");
debug('');
debug("Value 'auto':");
-e.style.webkitTextUnderlinePosition = 'auto';
-testElementStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", "[object CSSPrimitiveValue]", "auto");
-testComputedStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", "[object CSSPrimitiveValue]", "auto");
+e.style.textUnderlinePosition = 'auto';
+testElementStyle("textUnderlinePosition", "text-underline-position", "[object CSSPrimitiveValue]", "auto");
+testComputedStyle("textUnderlinePosition", "text-underline-position", "[object CSSPrimitiveValue]", "auto");
debug('');
debug("Value 'alphabetic':");
-e.style.webkitTextUnderlinePosition = 'alphabetic';
-testElementStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", "[object CSSPrimitiveValue]", "alphabetic");
-testComputedStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", "[object CSSPrimitiveValue]", "alphabetic");
+e.style.textUnderlinePosition = 'alphabetic';
+testElementStyle("textUnderlinePosition", "text-underline-position", "[object CSSPrimitiveValue]", "alphabetic");
+testComputedStyle("textUnderlinePosition", "text-underline-position", "[object CSSPrimitiveValue]", "alphabetic");
debug('');
debug("Value 'under':");
-e.style.webkitTextUnderlinePosition = 'under';
-testElementStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", "[object CSSPrimitiveValue]", "under");
-testComputedStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", "[object CSSPrimitiveValue]", "under");
+e.style.textUnderlinePosition = 'under';
+testElementStyle("textUnderlinePosition", "text-underline-position", "[object CSSPrimitiveValue]", "under");
+testComputedStyle("textUnderlinePosition", "text-underline-position", "[object CSSPrimitiveValue]", "under");
debug('');
-testContainer.innerHTML = '<div id="test-parent" style="-webkit-text-underline-position: under;">hello <span id="test-ancestor">world</span></div>';
+testContainer.innerHTML = '<div id="test-parent" style="text-underline-position: under;">hello <span id="test-ancestor">world</span></div>';
debug("Ancestor inherits values from parent:");
e = document.getElementById('test-ancestor');
-testElementStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", null, "");
-testComputedStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", "[object CSSPrimitiveValue]", "under");
+testElementStyle("textUnderlinePosition", "text-underline-position", null, "");
+testComputedStyle("textUnderlinePosition", "text-underline-position", "[object CSSPrimitiveValue]", "under");
debug('');
debug("Value 'auto alphabetic':");
-e.style.webkitTextUnderlinePosition = 'auto alphabetic';
-testElementStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", null, "");
+e.style.textUnderlinePosition = 'auto alphabetic';
+testElementStyle("textUnderlinePosition", "text-underline-position", null, "");
debug('');
debug("Value 'auto under':");
-e.style.webkitTextUnderlinePosition = 'auto under';
-testElementStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", null, "");
+e.style.textUnderlinePosition = 'auto under';
+testElementStyle("textUnderlinePosition", "text-underline-position", null, "");
debug('');
debug("Value 'under under':");
-e.style.webkitTextUnderlinePosition = 'under under';
-testElementStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", null, "");
+e.style.textUnderlinePosition = 'under under';
+testElementStyle("textUnderlinePosition", "text-underline-position", null, "");
debug('');
debug("Value 'under under under':");
-e.style.webkitTextUnderlinePosition = 'auto alphabetic under';
-testElementStyle("webkitTextUnderlinePosition", "-webkit-text-underline-position", null, "");
+e.style.textUnderlinePosition = 'auto alphabetic under';
+testElementStyle("textUnderlinePosition", "text-underline-position", null, "");
debug('');
document.body.removeChild(testContainer);
« no previous file with comments | « LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt ('k') | LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/style.css » ('j') | LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt » ('J')

Powered by Google App Engine
This is Rietveld 408576698