Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: Source/core/rendering/InlineFlowBox.h

Issue 40733004: Replace compile flag with runtime check for text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Julien's review #2 (rebased) Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/page/UseCounter.cpp ('k') | Source/core/rendering/InlineFlowBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 OwnPtr<RenderOverflow> m_overflow; 310 OwnPtr<RenderOverflow> m_overflow;
311 311
312 virtual bool isInlineFlowBox() const OVERRIDE FINAL { return true; } 312 virtual bool isInlineFlowBox() const OVERRIDE FINAL { return true; }
313 313
314 InlineBox* m_firstChild; 314 InlineBox* m_firstChild;
315 InlineBox* m_lastChild; 315 InlineBox* m_lastChild;
316 316
317 InlineFlowBox* m_prevLineBox; // The previous box that also uses our RenderO bject 317 InlineFlowBox* m_prevLineBox; // The previous box that also uses our RenderO bject
318 InlineFlowBox* m_nextLineBox; // The next box that also uses our RenderObjec t 318 InlineFlowBox* m_nextLineBox; // The next box that also uses our RenderObjec t
319 319
320 #if ENABLE(CSS3_TEXT)
321 // Maximum logicalTop among all children of an InlineFlowBox. Used to 320 // Maximum logicalTop among all children of an InlineFlowBox. Used to
322 // calculate the offset for TextUnderlinePositionUnder. 321 // calculate the offset for TextUnderlinePositionUnder.
323 void computeMaxLogicalTop(float& maxLogicalTop) const; 322 void computeMaxLogicalTop(float& maxLogicalTop) const;
324 #endif // CSS3_TEXT 323
325 private: 324 private:
326 unsigned m_includeLogicalLeftEdge : 1; 325 unsigned m_includeLogicalLeftEdge : 1;
327 unsigned m_includeLogicalRightEdge : 1; 326 unsigned m_includeLogicalRightEdge : 1;
328 unsigned m_hasTextChildren : 1; 327 unsigned m_hasTextChildren : 1;
329 unsigned m_hasTextDescendants : 1; 328 unsigned m_hasTextDescendants : 1;
330 unsigned m_descendantsHaveSameLineHeightAndBaseline : 1; 329 unsigned m_descendantsHaveSameLineHeightAndBaseline : 1;
331 330
332 protected: 331 protected:
333 // The following members are only used by RootInlineBox but moved here to ke ep the bits packed. 332 // The following members are only used by RootInlineBox but moved here to ke ep the bits packed.
334 333
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 } 379 }
381 380
382 } // namespace WebCore 381 } // namespace WebCore
383 382
384 #ifndef NDEBUG 383 #ifndef NDEBUG
385 // Outside the WebCore namespace for ease of invocation from gdb. 384 // Outside the WebCore namespace for ease of invocation from gdb.
386 void showTree(const WebCore::InlineFlowBox*); 385 void showTree(const WebCore::InlineFlowBox*);
387 #endif 386 #endif
388 387
389 #endif // InlineFlowBox_h 388 #endif // InlineFlowBox_h
OLDNEW
« no previous file with comments | « Source/core/page/UseCounter.cpp ('k') | Source/core/rendering/InlineFlowBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698