LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt - Issue 40733004: Replace compile flag with runtime check for text-underline-position

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt

Issue 40733004: Replace compile flag with runtime check for text-underline-position (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed a typo in static function compileUnderlineOffset signature / Rebase Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/css3-text/css3-text-decoration/text-underline-position/style.css ('k') | LayoutTests/webexposed/css-properties-as-js-properties-expected.txt » ('j') | Source/core/css/CSSParser-in.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 This test (crudely) documents Blink's web-exposed CSS properties. All changes t o this list should go through Blink's feature review process: http://www.chromiu m.org/blink#new-features	1 This test (crudely) documents Blink's web-exposed CSS properties. All changes t o this list should go through Blink's feature review process: http://www.chromiu m.org/blink#new-features

2	2

3 alignContent	3 alignContent

4 alignItems	4 alignItems

5 alignSelf	5 alignSelf

6 alignmentBaseline	6 alignmentBaseline

7 background	7 background

8 backgroundAttachment	8 backgroundAttachment

9 backgroundClip	9 backgroundClip

10 backgroundColor	10 backgroundColor

(...skipping 174 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
185 textOverflow	185 textOverflow

186 textOverlineColor	186 textOverlineColor

187 textOverlineMode	187 textOverlineMode

188 textOverlineStyle	188 textOverlineStyle

189 textOverlineWidth	189 textOverlineWidth

190 textRendering	190 textRendering

191 textShadow	191 textShadow

192 textTransform	192 textTransform

193 textUnderlineColor	193 textUnderlineColor

194 textUnderlineMode	194 textUnderlineMode

	195 textUnderlinePosition
	Julien - ping for review 2013/10/31 22:54:07 That is NOT OK. We don't want text-underline-posit That is NOT OK. We don't want text-underline-position in stable (ie if "Enable experimental Web feature" is off). This means you have to implement a filter in core/page/RuntimeCSSEnabled.cpp (see setPropertySwitchesFromRuntimeFeatures). abinader 2013/11/01 12:16:42 Yes, absolutely right! Fixed in next patch :-) Show quoted text On 2013/10/31 22:54:07, Julien Chaffraix - PST wrote: > That is NOT OK. We don't want text-underline-position in stable (ie if "Enable > experimental Web feature" is off). > > This means you have to implement a filter in core/page/RuntimeCSSEnabled.cpp > (see setPropertySwitchesFromRuntimeFeatures). Yes, absolutely right! Fixed in next patch :-)
195 textUnderlineStyle	196 textUnderlineStyle

196 textUnderlineWidth	197 textUnderlineWidth

197 top	198 top

198 touchActionDelay	199 touchActionDelay

199 transition	200 transition

200 transitionDelay	201 transitionDelay

201 transitionDuration	202 transitionDuration

202 transitionProperty	203 transitionProperty

203 transitionTimingFunction	204 transitionTimingFunction

204 unicodeBidi	205 unicodeBidi

(...skipping 156 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
361 whiteSpace	362 whiteSpace

362 widows	363 widows

363 width	364 width

364 wordBreak	365 wordBreak

365 wordSpacing	366 wordSpacing

366 wordWrap	367 wordWrap

367 writingMode	368 writingMode

368 zIndex	369 zIndex

369 zoom	370 zoom

370	371

OLD	NEW