Add a MotionEventGeneric implementation

Add a MotionEventGeneric implementation

Provide a reference implementation of the MotionEvent interface, usable by mock
implementations and platform-specific implementations.

BUG=394562
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285110

[jdduke (slow), 2014-07-22 23:13:52]

tdresser@: I went ahead and factored out this change from the MotionEventBuffer
change, PTAL, thanks.

[tdresser, 2014-07-23 12:53:45]

https://codereview.chromium.org/407313002/diff/1/ui/events/gesture_detection/...
File ui/events/gesture_detection/motion_event_generic_unittest.cc (right):

https://codereview.chromium.org/407313002/diff/1/ui/events/gesture_detection/...
ui/events/gesture_detection/motion_event_generic_unittest.cc:55:
ASSERT_TRUE(clone);
Looks like you forgot a |EXPECT_EQ(event, *clone)|.

https://codereview.chromium.org/407313002/diff/1/ui/events/test/mock_motion_e...
File ui/events/test/mock_motion_event.cc (right):

https://codereview.chromium.org/407313002/diff/1/ui/events/test/mock_motion_e...
ui/events/test/mock_motion_event.cc:83: return
static_cast<int>(GetPointerCount()) - 1;
This should probably return the event's actual |action_index_|.

https://codereview.chromium.org/407313002/diff/1/ui/events/test/mock_motion_e...
ui/events/test/mock_motion_event.cc:92: return
MotionEventGeneric::GetRawX(pointer_index) + raw_offset_.x();
Ideally we'd be storing the right thing in |raw_{x,y}| already.
If we can't entirely do away with |raw_offset_|, could we at least cache the
correct raw values in |raw_{x,y}|?

https://codereview.chromium.org/407313002/diff/1/ui/events/test/mock_motion_e...
ui/events/test/mock_motion_event.cc:109: void MockMotionEvent::SetId(int new_id)
{
Are we keeping these around just to avoid doing a string replace in the tests?
If so, I vote we bite the bullet now, and get rid of these methods that just
forward to the MotionEventGeneric.

https://codereview.chromium.org/407313002/diff/1/ui/events/test/mock_motion_e...
ui/events/test/mock_motion_event.cc:120: set_action(GetPointerCount() > 1 ?
ACTION_POINTER_DOWN : ACTION_DOWN);
This (and below) should |set_action_index| when appropriate.

https://codereview.chromium.org/407313002/diff/1/ui/events/test/mock_motion_e...
File ui/events/test/mock_motion_event.h (right):

https://codereview.chromium.org/407313002/diff/1/ui/events/test/mock_motion_e...
ui/events/test/mock_motion_event.h:65: gfx::Vector2dF raw_offset_;
Now that we're storing separate values for |raw_x| and |raw_y|, we shouldn't
really be keeping a separate |raw_offset_| around.

That might be more trouble than it's worth though...

[jdduke (slow), 2014-07-23 17:20:56]

sadrul@: Owner review for events/BUILD.gn and events/test? Thanks.

https://codereview.chromium.org/407313002/diff/1/ui/events/gesture_detection/...
File ui/events/gesture_detection/motion_event_generic_unittest.cc (right):

https://codereview.chromium.org/407313002/diff/1/ui/events/gesture_detection/...
ui/events/gesture_detection/motion_event_generic_unittest.cc:55:
ASSERT_TRUE(clone);
On 2014/07/23 12:53:45, tdresser wrote:
> Looks like you forgot a |EXPECT_EQ(event, *clone)|.

Done.

https://codereview.chromium.org/407313002/diff/1/ui/events/test/mock_motion_e...
File ui/events/test/mock_motion_event.cc (right):

https://codereview.chromium.org/407313002/diff/1/ui/events/test/mock_motion_e...
ui/events/test/mock_motion_event.cc:83: return
static_cast<int>(GetPointerCount()) - 1;
On 2014/07/23 12:53:45, tdresser wrote:
> This should probably return the event's actual |action_index_|.

Yeah, it's a little tricker but doable.

https://codereview.chromium.org/407313002/diff/1/ui/events/test/mock_motion_e...
ui/events/test/mock_motion_event.cc:92: return
MotionEventGeneric::GetRawX(pointer_index) + raw_offset_.x();
On 2014/07/23 12:53:45, tdresser wrote:
> Ideally we'd be storing the right thing in |raw_{x,y}| already.
> If we can't entirely do away with |raw_offset_|, could we at least cache the
> correct raw values in |raw_{x,y}|?

I'll rip it out.

https://codereview.chromium.org/407313002/diff/1/ui/events/test/mock_motion_e...
ui/events/test/mock_motion_event.cc:109: void MockMotionEvent::SetId(int new_id)
{
On 2014/07/23 12:53:45, tdresser wrote:
> Are we keeping these around just to avoid doing a string replace in the tests?
> If so, I vote we bite the bullet now, and get rid of these methods that just
> forward to the MotionEventGeneric.

Done.

https://codereview.chromium.org/407313002/diff/1/ui/events/test/mock_motion_e...
ui/events/test/mock_motion_event.cc:120: set_action(GetPointerCount() > 1 ?
ACTION_POINTER_DOWN : ACTION_DOWN);
On 2014/07/23 12:53:45, tdresser wrote:
> This (and below) should |set_action_index| when appropriate.

Done.

https://codereview.chromium.org/407313002/diff/1/ui/events/test/mock_motion_e...
File ui/events/test/mock_motion_event.h (right):

https://codereview.chromium.org/407313002/diff/1/ui/events/test/mock_motion_e...
ui/events/test/mock_motion_event.h:65: gfx::Vector2dF raw_offset_;
On 2014/07/23 12:53:45, tdresser wrote:
> Now that we're storing separate values for |raw_x| and |raw_y|, we shouldn't
> really be keeping a separate |raw_offset_| around.
> 
> That might be more trouble than it's worth though...

Yeah, I actually ripped this out, then found a couple places where we want
|raw_offset_| to be persistent as new  pointers are pushed.  However, that
persistence can be done in different ways so I'll update accordingly.

[tdresser, 2014-07-23 18:06:15]

Awesome, thanks!
LGTM.

https://codereview.chromium.org/407313002/diff/20001/ui/events/events.gyp
File ui/events/events.gyp (right):

https://codereview.chromium.org/407313002/diff/20001/ui/events/events.gyp#new...
ui/events/events.gyp:291: # GN vesrion: //ui/events:events_unittests
vesrion!

[sadrul, 2014-07-23 18:31:53]

said files lgtm

[jdduke (slow), 2014-07-23 18:35:48]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-07-23 18:37:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jdduke@chromium.org/407313002/40001

[jdduke (slow), 2014-07-23 21:40:01]

https://codereview.chromium.org/407313002/diff/20001/ui/events/events.gyp
File ui/events/events.gyp (right):

https://codereview.chromium.org/407313002/diff/20001/ui/events/events.gyp#new...
ui/events/events.gyp:291: # GN vesrion: //ui/events:events_unittests
On 2014/07/23 18:06:15, tdresser wrote:
> vesrion!

Done.

[commit-bot: I haz the power, 2014-07-24 02:14:22]

Change committed as 285110