Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 407303003: Re-Reland: [Telemetry] Fix a flake in android browser finder. (Closed)

Created:
6 years, 5 months ago by tonyg
Modified:
6 years, 5 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-Reland: [Telemetry] Fix a flake in android browser finder. It turns out that a few bots have psutils 0.4.1 and the set_cpu_affinity API was introduced in 0.5. I'm investigating why bots have differing versions, but for now this patch makes us robust to any psutil version. BUG=395228 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285372

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -12 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 1 2 3 2 chunks +20 lines, -12 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
tonyg
6 years, 5 months ago (2014-07-23 22:02:24 UTC) #1
dtu
lgtm
6 years, 5 months ago (2014-07-23 22:03:10 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 5 months ago (2014-07-23 22:23:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/407303003/40001
6 years, 5 months ago (2014-07-23 22:26:06 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 04:28:40 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 04:31:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/173225) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/162256) ios_rel_device_ninja ...
6 years, 5 months ago (2014-07-24 04:31:19 UTC) #7
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 5 months ago (2014-07-24 13:46:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/407303003/40001
6 years, 5 months ago (2014-07-24 13:48:08 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 13:57:56 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 13:59:20 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/32679)
6 years, 5 months ago (2014-07-24 13:59:21 UTC) #12
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 5 months ago (2014-07-24 14:33:40 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/407303003/40001
6 years, 5 months ago (2014-07-24 14:35:17 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 14:44:31 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 14:46:39 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/173368) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/162400) ios_rel_device_ninja ...
6 years, 5 months ago (2014-07-24 14:46:40 UTC) #17
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 5 months ago (2014-07-24 15:24:15 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/407303003/60001
6 years, 5 months ago (2014-07-24 15:25:39 UTC) #19
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 21:13:01 UTC) #20
Message was sent while issue was closed.
Change committed as 285372

Powered by Google App Engine
This is Rietveld 408576698