Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 407253002: Reland: [Telemetry] Fix a flake in android browser finder. (Closed)

Created:
6 years, 5 months ago by tonyg
Modified:
6 years, 5 months ago
Reviewers:
dtu, sadrul
CC:
chromium-reviews, telemetry+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Reland: [Telemetry] Fix a flake in android browser finder. This is the same as before, except that we now support older and newer versions of psutil. BUG=395228 patch from issue 394423002 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 2 chunks +16 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tonyg
6 years, 5 months ago (2014-07-22 21:33:22 UTC) #1
dtu
lgtm
6 years, 5 months ago (2014-07-22 21:42:21 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 5 months ago (2014-07-22 21:43:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/407253002/1
6 years, 5 months ago (2014-07-22 21:44:56 UTC) #4
commit-bot: I haz the power
Change committed as 284832
6 years, 5 months ago (2014-07-23 01:50:51 UTC) #5
sadrul
6 years, 5 months ago (2014-07-23 04:01:37 UTC) #6
Message was sent while issue was closed.
This seems to have broken an android bot with the following error:

Traceback (most recent call last):
  <module> at tools/perf/run_tests:25
    sys.exit(run_tests.RunTestsCommand.main())
  _LoggingRestoreWrapper at tools/telemetry/telemetry/unittest/run_tests.py:97
    return func(*args, **kwargs)
  main at tools/telemetry/telemetry/unittest/run_tests.py:157
    return super(RunTestsCommand, cls).main(args)
  main at tools/telemetry/telemetry/core/command_line.py:77
    cls.ProcessCommandLineArgs(parser, options)
  ProcessCommandLineArgs at tools/telemetry/telemetry/unittest/run_tests.py:135
    possible_browser = browser_finder.FindBrowser(args)
  Cacher at tools/telemetry/telemetry/decorators.py:26
    cache[key] = obj(*args, **kwargs)
  FindBrowser at tools/telemetry/telemetry/core/browser_finder.py:73
    curr_browsers = finder.FindAllAvailableBrowsers(options)
  FindAllAvailableBrowsers at
tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py:224
    proc.set_cpu_affinity([0])  # Older versions.
AttributeError: 'Process' object has no attribute 'set_cpu_affinity'

Locals:
  adb            : <telemetry.core.backends.adb_commands.AdbCommands object at
0x31c0cd0>
  device         : '01ccfbd00e13a2b6'
  devices        : ['01ccfbd00e13a2b6']
  finder_options : [('android_device', '01ccfbd00e13a2b6'), ('android_rndis',
False), ('browser_executable', None), ('browser_options',
[('_extra_browser_args', set([])), ('browser_type', 'android-chrome-shell'),
('browser_user_agent_type', None),
('clear_sytem_cache_for_browser_and_profile_on_start', False),
('disable_component_extensions_with_background_pages', True),
('dont_override_profile', False), ('extra_wpr_args', []), ('netsim', None),
('no_proxy_server', False), ('profile_dir', None), ('profile_type', 'clean'), (
... ions_to_load', []), ('extra_browser_args_as_string', None),
('extra_wpr_args_as_string', None), ('gtest_output', None), ('interactive',
None), ('netsim', None), ('no_performance_mode', None), ('output_file', None),
('output_profile_path', None), ('positional_args', []), ('print_bootstrap_deps',
None), ('profile_dir', None), ('profiler', None), ('repeat_count', 1),
('run_disabled_tests', False), ('show_stdout', None),
('skip_navigate_on_repeat', False), ('use_devtools_active_port', None),
('verbosity', 0)] (truncated)
  logging        : <module 'logging' from
'/usr/lib/python2.7/logging/__init__.pyc'>
  proc           : <psutil.Process(pid=5594, name='adb') at 52170448>

< tools/perf/run_tests --browser android-chrome-shell --device 01ccfbd00e13a2b6
ERROR: process exited with code 1


Link:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14...

Powered by Google App Engine
This is Rietveld 408576698