Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 407243002: Some linking fixes for GN build. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, darin-cc_chromium.org, jam, tdresser+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Some linking fixes for GN build. Add some content_shell targets. content_shell itself doesn't link yet so it's commented out, but some assocaited libs now compile. This fixes a variety of out-of-date sources lists to get some targets closer to linking in the GN build. Add xdisplaycheckk target Update GYP files for GN names Rename events_ipc R=hclam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284974

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+532 lines, -31 lines) Patch
M BUILD.gn View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M content/browser/tracing/tracing_resources.gyp View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/content.gyp View 1 2 7 chunks +7 lines, -0 lines 0 comments Download
M content/content_resources.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/content_shell.gypi View 1 2 8 chunks +9 lines, -17 lines 0 comments Download
M content/public/plugin/BUILD.gn View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/utility/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A content/shell/BUILD.gn View 1 2 1 chunk +467 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M ppapi/BUILD.gn View 1 10 chunks +20 lines, -1 line 0 comments Download
A + tools/xdisplaycheck/BUILD.gn View 1 1 chunk +4 lines, -5 lines 0 comments Download
M tools/xdisplaycheck/xdisplaycheck.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/ipc/BUILD.gn View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ui/events/ipc/events_ipc.gyp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
https://codereview.chromium.org/407243002/diff/40001/content/content_shell.gypi File content/content_shell.gypi (left): https://codereview.chromium.org/407243002/diff/40001/content/content_shell.gypi#oldcode251 content/content_shell.gypi:251: ['exclude', 'WebTestThemeEngineMock.cpp'], This doesn't exist so this line was ...
6 years, 5 months ago (2014-07-22 23:18:13 UTC) #1
Alpha Left Google
lgtm
6 years, 5 months ago (2014-07-22 23:44:47 UTC) #2
brettw
6 years, 5 months ago (2014-07-23 17:15:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r284974 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698