Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 407193002: QUIC - undo the chromium specific changes from the following CL which (Closed)

Created:
6 years, 5 months ago by ramant (doing other things)
Modified:
6 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

QUIC - undo the chromium specific changes from the following CL which did "Moving work from the QuicSession constructor to InitializeSession()". https://codereview.chromium.org/393953009/ Merge internal change: 70661792 This CL fixes the crash bug in net::QuicSession::IsCryptoHandshakeConfirmed. We are accessing crypto_stream_ before it was created. This could be triggered if the computer is slow or goes to sleep and crypto handshake not completed timer goes off. BUG=395790 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -38 lines) Patch
M net/quic/quic_client_session.h View 2 chunks +4 lines, -6 lines 0 comments Download
M net/quic/quic_client_session.cc View 4 chunks +15 lines, -18 lines 0 comments Download
M net/quic/quic_client_session_test.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ramant (doing other things)
6 years, 5 months ago (2014-07-22 18:23:47 UTC) #1
Ryan Hamilton
lgtm
6 years, 5 months ago (2014-07-22 18:36:34 UTC) #2
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 5 months ago (2014-07-22 18:37:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/407193002/1
6 years, 5 months ago (2014-07-22 18:38:57 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 23:19:16 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 01:40:59 UTC) #6
Message was sent while issue was closed.
Change committed as 284827

Powered by Google App Engine
This is Rietveld 408576698