Added an annotation to label Integration tests.

Added an annotation to label Integration tests.


An IntegrationTest label will be required for tests that may require
a greater timeout value than LargeTest allows. These tests will run
against real instances of other services (e.g. Search). They may use
command-line flags to change the backends that are being tested against.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284821

[jbudorick, 2014-07-22 17:46:50]

+klundberg

I'm ok with this % the EnormousTest weirdness, but I'll let the others take a
look.

https://codereview.chromium.org/407173002/diff/1/base/test/android/javatests/...
File
base/test/android/javatests/src/org/chromium/base/test/util/IntegrationTest.java
(right):

https://codereview.chromium.org/407173002/diff/1/base/test/android/javatests/...
base/test/android/javatests/src/org/chromium/base/test/util/IntegrationTest.java:1:
// Copyright 2014 The Chromium Authors. All rights reserved.
Why is this comparing to EnormousTest...?

[nyquist, 2014-07-22 17:52:52]

why have both EnourmousTest and IntegrationTest?

[klundberg, 2014-07-22 18:43:26]

To answer Tommy's question:
EnormousTest just means that the test depend on external webpages whereas
integration tests will run against real instances of for example Search
(although in some cases, unreleased versions). As such, integration tests will
use command line flags to change backends and we only want to run actual
integration tests using these backends, not enormous tests.

If needed, I can explain more in person although I'm in London this week.

Yojan, I'm not sure if you can provide a better description for the annotation
to make the difference a bit more clear? 
I tried to come up with a suggestion but without luck:-)

https://codereview.chromium.org/407173002/diff/1/base/test/android/javatests/...
File
base/test/android/javatests/src/org/chromium/base/test/util/IntegrationTest.java
(right):

https://codereview.chromium.org/407173002/diff/1/base/test/android/javatests/...
base/test/android/javatests/src/org/chromium/base/test/util/IntegrationTest.java:1:
// Copyright 2014 The Chromium Authors. All rights reserved.
On 2014/07/22 17:46:50, jbudorick wrote:
> Why is this comparing to EnormousTest...?

I see this happen quite often where codereview compares to an existing file when
a new file is added since the new file is similar to the old file (or something
like that).

[nyquist, 2014-07-22 19:47:58]

if klundberg@ wants this then lgtm

[klundberg, 2014-07-22 19:52:46]

On 2014/07/22 19:47:58, nyquist wrote:
> if klundberg@ wants this then lgtm

Thanks, Tommy! :-)

lgtm from me too...even if you cannot come up with a better description:-)

[yojan, 2014-07-22 20:59:39]

The CQ bit was checked by yojan@google.com

[commit-bot: I haz the power, 2014-07-22 21:01:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yojan@google.com/407173002/20001

[yojan, 2014-07-22 21:01:39]

On 2014/07/22 19:52:46, klundberg wrote:
> On 2014/07/22 19:47:58, nyquist wrote:
> > if klundberg@ wants this then lgtm
> 
> Thanks, Tommy! :-)
> 
> lgtm from me too...even if you cannot come up with a better description:-)

I have updated the example to try to distinguish the two a little bit more.
Another reason I could think of might be to be able to configure the timeout for
these integration tests later without affecting the others.

[nyquist, 2014-07-22 21:24:23]

Could you update the change description as well?

[yojan, 2014-07-22 21:30:06]

On 2014/07/22 21:24:23, nyquist wrote:
> Could you update the change description as well?

Sure, done.

[nyquist, 2014-07-22 22:08:40]

Nit: Could you wrap the description at ~70 chars?

Anyway, still lgtm

[commit-bot: I haz the power, 2014-07-23 00:15:05]

Change committed as 284821

[klundberg, 2014-07-23 08:07:16]

Thanks, Yojan!

And still lgtm

[candaceku, 2015-03-26 01:22:44]

On 2014/07/22 17:46:50, jbudorick wrote:
> +klundberg
> 
> I'm ok with this % the EnormousTest weirdness, but I'll let the others take a
> look.
> 
>
https://codereview.chromium.org/407173002/diff/1/base/test/android/javatests/...
> File
>
base/test/android/javatests/src/org/chromium/base/test/util/IntegrationTest.java
> (right):
> 
>
https://codereview.chromium.org/407173002/diff/1/base/test/android/javatests/...
>
base/test/android/javatests/src/org/chromium/base/test/util/IntegrationTest.java:1:
> // Copyright 2014 The Chromium Authors. All rights reserved.
> Why is this comparing to EnormousTest...?