Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 407163002: fix nacl (Closed)

Created:
6 years, 5 months ago by caryclark
Modified:
6 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

fix nacl TBR=robertphillips NOTRY=true NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/fa9d1356d977556b71980b7affee25dffd9f9c83

Patch Set 1 #

Patch Set 2 : remove command line args #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M platform_tools/nacl/src/nacl_interface.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 5 months ago (2014-07-22 17:36:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/407163002/1
6 years, 5 months ago (2014-07-22 17:37:03 UTC) #2
robertphillips
lgtm
6 years, 5 months ago (2014-07-22 17:37:58 UTC) #3
robertphillips
The CQ bit was unchecked by robertphillips@google.com
6 years, 5 months ago (2014-07-22 17:39:55 UTC) #4
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 5 months ago (2014-07-22 17:39:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/407163002/1
6 years, 5 months ago (2014-07-22 17:40:03 UTC) #6
commit-bot: I haz the power
Change committed as fa9d1356d977556b71980b7affee25dffd9f9c83
6 years, 5 months ago (2014-07-22 17:40:11 UTC) #7
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 5 months ago (2014-07-22 17:49:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/407163002/20001
6 years, 5 months ago (2014-07-22 17:50:03 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 17:50:04 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 17:50:05 UTC) #11
Failed to apply patch for platform_tools/nacl/src/nacl_interface.cpp:
While running git apply --index -p1;
  error: patch failed: platform_tools/nacl/src/nacl_interface.cpp:24
  error: platform_tools/nacl/src/nacl_interface.cpp: patch does not apply

Patch:       platform_tools/nacl/src/nacl_interface.cpp
Index: platform_tools/nacl/src/nacl_interface.cpp
diff --git a/platform_tools/nacl/src/nacl_interface.cpp
b/platform_tools/nacl/src/nacl_interface.cpp
index
09d55c3feccdd2473024a11638de038af2232ba1..297458dd8e624bc348be5524b9bfbb06d44d3b94
100644
--- a/platform_tools/nacl/src/nacl_interface.cpp
+++ b/platform_tools/nacl/src/nacl_interface.cpp
@@ -24,7 +24,7 @@ class SkiaInstance;
 SkiaInstance* gPluginInstance;
 
 // Main entry point for the app we're linked into
-extern int tool_main(int, char**);
+extern int test_main();
 
 // Tokenize a command line and store it in argc and argv.
 void SkStringToProgramArgs(const SkString commandLine, int* argc, char*** argv)
{
@@ -68,7 +68,7 @@ void RunProgram(const SkString& commandLine) {
     int argc;
     char** argv;
     SkStringToProgramArgs(commandLine, &argc, &argv);
-    tool_main(argc, argv);
+    test_main();
 }

Powered by Google App Engine
This is Rietveld 408576698