Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4010)

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 407093015: GN: Make chrome/{browser,common,renderer} compile on mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: line wrap and remove gpu_memory_buffer_factory_x11.cc from non-x11 builds Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/BUILD.gn ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index 0960e3b7d9abd7618144c754a72664d59d40fe83..13e05dea87f2444d0a1c524cf512e315f7a83bbe 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -293,37 +293,17 @@ static_library("ui") {
"tabs/tab_resources.h",
]
deps += [
+ "//third_party/google_toolbox_for_mac",
+ ":generate_localizer",
#'../third_party/apple_sample_code/apple_sample_code.gyp:apple_sample_code', TODO(GYP)
- #'../third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp:google_toolbox_for_mac', TODO(GYP)
#'../third_party/molokocacao/molokocacao.gyp:molokocacao', TODO(GYP)
#'../third_party/mozilla/mozilla.gyp:mozilla', TODO(GYP)
]
+ include_dirs = [ "$target_gen_dir" ]
libs += [ "Quartz.framework" ]
- # TODO(GYP)
- #'actions': [
- # {
- # # This action is used to extract the localization data from xib
- # # files and generate table for the ui localizer from it.
- # 'variables': {
- # 'xib_localizer_tool_path':
- # 'tools/build/mac/generate_localizer',
- # },
- # 'includes': [
- # 'chrome_nibs.gypi',
- # ],
- # 'action_name': 'Process xibs for localization',
- # 'inputs': [
- # '<(xib_localizer_tool_path)',
- # '<@(mac_translated_xibs)',
- # ],
- # 'outputs': [
- # '<(INTERMEDIATE_DIR)/ui_localizer_table.h',
- # ],
- # 'action': ['<(xib_localizer_tool_path)',
- # '<@(_outputs)',
- # '<@(mac_translated_xibs)'],
- # },
- #]
+ configs += [
+ "//third_party/google_toolbox_for_mac:google_toolbox_for_mac_config",
+ ]
} else { # non-Mac.
sources += rebase_path(gypi_values.chrome_browser_ui_non_mac_sources,
".", "//chrome")
@@ -418,3 +398,22 @@ static_library("ui") {
deps += [ "//third_party/hunspell" ]
}
}
+
+if (is_mac) {
+ nib_gypi_values = exec_script(
+ "//build/gypi_to_gn.py",
+ [ rebase_path("../../chrome_nibs.gypi") ],
+ "scope",
+ [ "../../chrome_nibs.gypi" ])
+
+ action("generate_localizer") {
+ script = "//chrome/tools/build/mac/generate_localizer"
+ sources = [ ]
+ table_path = "$target_gen_dir/ui_localizer_table.h"
+ outputs = [ table_path ]
+ args = [ rebase_path(table_path, root_build_dir) ] +
+ rebase_path(nib_gypi_values.mac_translated_xibs,
+ root_build_dir,
+ "//chrome")
+ }
+}
« no previous file with comments | « chrome/browser/extensions/BUILD.gn ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698