Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3286)

Unified Diff: breakpad/BUILD.gn

Issue 407093015: GN: Make chrome/{browser,common,renderer} compile on mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: line wrap and remove gpu_memory_buffer_factory_x11.cc from non-x11 builds Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/secondary/third_party/google_toolbox_for_mac/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/BUILD.gn
diff --git a/breakpad/BUILD.gn b/breakpad/BUILD.gn
index 6fef7b06bca9d93a06c898ed3fab8afd62478d95..bfec4124714892807b24c6eaae4cc0cafb563e78 100644
--- a/breakpad/BUILD.gn
+++ b/breakpad/BUILD.gn
@@ -24,6 +24,14 @@ config("internal_config") {
}
}
+config("client_config") {
+ include_dirs = [ "src" ]
+ if (is_android) {
+ include_dirs += [ "src/common/android/include" ]
+ }
+}
+
+
# minidump_stackwalk and minidump_dump are tool-type executables that do
# not build on iOS.
if (current_toolchain == host_toolchain && !is_win) {
@@ -241,6 +249,7 @@ if (is_mac) {
include_dirs = [
"src/client/apple/Framework",
"src/common/mac",
+ "src",
]
libs = [
"CoreServices.framework",
@@ -281,9 +290,14 @@ if (is_mac) {
deps = [
":utilities",
":crash_inspector",
- ":crash_report_sender",
+ # TODO(GYP): Make this link
+ #":crash_report_sender",
]
}
+
+ group("client") {
+ direct_dependent_configs = [ ":client_config" ]
+ }
}
if (is_linux || is_android) {
@@ -362,13 +376,6 @@ if (is_linux && current_toolchain == host_toolchain) {
include_dirs = [ "src" ]
}
- config("client_config") {
- include_dirs = [ "src" ]
- if (is_android) {
- include_dirs += [ "src/common/android/include" ]
- }
- }
-
static_library("client") {
sources = [
"src/client/linux/crash_generation/crash_generation_client.cc",
@@ -645,3 +652,9 @@ if (is_ios) {
# TODO(GYP) There is some XCode-only targets like ninja-breakpad.
}
+
+if (is_win) {
+ group("client") {
+ direct_dependent_configs = [ ":client_config" ]
+ }
+}
« no previous file with comments | « no previous file | build/secondary/third_party/google_toolbox_for_mac/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698