Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2678)

Unified Diff: chrome/common/BUILD.gn

Issue 407093015: GN: Make chrome/{browser,common,renderer} compile on mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index ba6e645dc019c237432b0d4c378124f5e8d987a9..2a405a9df6acc8c5187b61668b25393ac771cba4 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -194,7 +194,10 @@ static_library("common") {
]
deps += [
"//third_party/mach_override",
- #'../third_party/google_toolbox_for_mac/google_toolbox_for_mac.gyp:google_toolbox_for_mac', TODO(GYP)
+ "//third_party/google_toolbox_for_mac",
+ ]
+ include_dirs = [
+ "//breakpad/src",
brettw 2014/07/23 18:04:16 What is this for? Can depending on breakpad do thi
jamesr 2014/07/23 19:57:29 I just copied what the gyp build does, but it's pr
brettw 2014/07/23 20:02:38 Try just removing it, I give 80% chance it works.
]
}
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698