GN: Make chrome/{browser,common,renderer} compile on mac

GN: Make chrome/{browser,common,renderer} compile on mac

This adds GN rules for google_toolbox_for_mac and generate_localize as
well as fixing up various source issues that show up on the mac build.
With this chrome/{browser,common,renderer} compile on mac (but probably
don't fully link).

R=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286364

[jamesr, 2014-07-23 06:35:23]

Depends on https://codereview.chromium.org/389083002

[brettw, 2014-07-23 18:04:17]

https://codereview.chromium.org/407093015/diff/1/chrome/common/BUILD.gn
File chrome/common/BUILD.gn (right):

https://codereview.chromium.org/407093015/diff/1/chrome/common/BUILD.gn#newco...
chrome/common/BUILD.gn:200: "//breakpad/src",
What is this for? Can depending on breakpad do this for us? Otherwise, can we
have a comment here explaining it?

[jamesr, 2014-07-23 19:57:29]

https://codereview.chromium.org/407093015/diff/1/chrome/common/BUILD.gn
File chrome/common/BUILD.gn (right):

https://codereview.chromium.org/407093015/diff/1/chrome/common/BUILD.gn#newco...
chrome/common/BUILD.gn:200: "//breakpad/src",
On 2014/07/23 18:04:16, brettw wrote:
> What is this for? Can depending on breakpad do this for us? Otherwise, can we
> have a comment here explaining it?

I just copied what the gyp build does, but it's probably worth investigating
what is going on.

[brettw, 2014-07-23 20:02:39]

https://codereview.chromium.org/407093015/diff/1/chrome/common/BUILD.gn
File chrome/common/BUILD.gn (right):

https://codereview.chromium.org/407093015/diff/1/chrome/common/BUILD.gn#newco...
chrome/common/BUILD.gn:200: "//breakpad/src",
Try just removing it, I give 80% chance it works.

[jamesr, 2014-07-23 20:03:55]

On 2014/07/23 20:02:39, brettw wrote:
> https://codereview.chromium.org/407093015/diff/1/chrome/common/BUILD.gn
> File chrome/common/BUILD.gn (right):
> 
>
https://codereview.chromium.org/407093015/diff/1/chrome/common/BUILD.gn#newco...
> chrome/common/BUILD.gn:200: "//breakpad/src",
> Try just removing it, I give 80% chance it works.

No it doesn't - we #include things from this target that rely on relative in
breakpad headers.  What I don't understand (yet) is why this is
platform-specific (in gyp we add this path in win and mac afaik, in different
blocks) and why we can't get it from dependencies

[jamesr, 2014-07-24 06:40:48]

OK, what's going on here is that chrome/common/crash_keys.cc #includes some
breakpad headers in order to extract some size values.  On mac, it #includes
breakpad/src/common/simple_string_dictionary.h, which is a pure inline class
(the .cc only has a compile assert) in order to get the value_size.  On windows,
it #includes breakpad/src/client/windows/common/ipc_protocol.h to get
kValueMaxLength.  Neither of these headers list any symbols that need to be
defined.  Interestingly the result of this computation on windows is 63 (as is
the hardcoded value on non-win/non-mac) but the computed value on mac is 254.  I
dunno why.

One option would be to put these headers in source_set()s containing only
headers and have chrome/common depend on them to pick up their required
#includes.  It'd a bit of a headache to do for just two headers, though,
especially since they'd have to be different on mac and win.  Another would be
to declare something these can depend on, which is weird since we don't need to
actually link anything against chrome/common/ code.  I could also just put the
values in.

Any strong preference?  If not I'll pick whatever seems most appealing after a
night's sleep.

[brettw, 2014-07-25 21:10:35]

I like a source set with the necessary header and call it "breakad_headers" or
whatever with the proper include paths as direct dependents.

[jamesr, 2014-07-29 06:13:41]

This just makes //breakpad:client be a group on windows and mac with a dependent
config for the include dirs so chrome/blah doesn't have to care about how the
headers get there, it just depends on //breakpad:client.  In combination with
https://codereview.chromium.org/424043002/ this makes chrome/{browser,common}
compile cleanly on my mac.  WDYT?

[brettw, 2014-07-29 20:36:47]

lgtm

https://codereview.chromium.org/407093015/diff/40001/chrome/browser/ui/BUILD.gn
File chrome/browser/ui/BUILD.gn (right):

https://codereview.chromium.org/407093015/diff/40001/chrome/browser/ui/BUILD....
chrome/browser/ui/BUILD.gn:415: rebase_path(nib_gypi_values.mac_translated_xibs,
root_build_dir, "//chrome")
Can you wrap this like you would C++?

[jamesr, 2014-07-29 23:46:17]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-07-29 23:48:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/407093015/60001

[jamesr, 2014-07-30 00:39:18]

The CQ bit was unchecked by jamesr@chromium.org

[jamesr, 2014-07-30 00:40:12]

Committed patchset #4 manually as r286364.