Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: mojo/services/network/url_loader_impl.cc

Issue 407093011: Allow URLRequests from one context to have different NetworkDelegates. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix mojo Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/network/url_loader_impl.cc
diff --git a/mojo/services/network/url_loader_impl.cc b/mojo/services/network/url_loader_impl.cc
index 7e53c4035852ec640a38d5e7a7a883b5f660eac3..ff2c80739dbcee5c159041f83b6929999ab8014c 100644
--- a/mojo/services/network/url_loader_impl.cc
+++ b/mojo/services/network/url_loader_impl.cc
@@ -13,6 +13,7 @@
#include "net/base/upload_bytes_element_reader.h"
#include "net/base/upload_data_stream.h"
#include "net/http/http_response_headers.h"
+#include "net/url_request/url_request_context.h"
namespace mojo {
namespace {
@@ -82,7 +83,8 @@ class UploadDataPipeElementReader : public net::UploadElementReader {
int buf_length,
const net::CompletionCallback& callback) OVERRIDE {
uint32_t bytes_read =
- std::min(BytesRemaining(), static_cast<uint64>(buf_length));
+ std::min(static_cast<uint32_t>(BytesRemaining()),
+ static_cast<uint32_t>(buf_length));
if (bytes_read > 0) {
ReadDataRaw(pipe_.get(), buf->data(), &bytes_read,
MOJO_READ_DATA_FLAG_NONE);
@@ -177,11 +179,11 @@ void URLLoaderImpl::Start(URLRequestPtr request,
return;
}
- url_request_.reset(
- new net::URLRequest(GURL(request->url),
- net::DEFAULT_PRIORITY,
- this,
- context_->url_request_context()));
+ url_request_ = context_->url_request_context()->CreateRequest(
+ GURL(request->url),
+ net::DEFAULT_PRIORITY,
+ this,
+ NULL);
url_request_->set_method(request->method);
if (request->headers) {
net::HttpRequestHeaders headers;

Powered by Google App Engine
This is Rietveld 408576698